jenkins-bot has submitted this change and it was merged.
Change subject: Empty view port when updating the snakview variation
......................................................................
Empty view port when updating the snakview variation
When canceling after changing from value snak type to another snak type,
the value variation is reset again.
Bug 67294
Change-Id: I430fa7862adff766af93bcd2f361df3a1ee189ca
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
Aude: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index 2ac0b35..8885e21 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -80,9 +80,8 @@
$property: null,
/**
- * The DOM node of the Snak's value or some message if the value is not
supported.
- * TODO later we will support 'novalue' and 'somevalue' snaks which
will probably be displayed
- * in this node as well somehow.
+ * The DOM node of the Snak's value, some message if the value is not
supported or "no value"/
+ * "some value" message.
* @type jQuery
*/
$snakValue: null,
@@ -661,6 +660,8 @@
variationType =
this._variation.variationSnakConstructor.TYPE;
this._recentVariationValues[ variationType ] =
this._variation.value();
+ this.$snakValue.empty();
+
// clean destruction of old variation in case variation
will change or property not set
this._variation.destroy();
this._variation = null;
--
To view, visit https://gerrit.wikimedia.org/r/143270
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I430fa7862adff766af93bcd2f361df3a1ee189ca
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
