jenkins-bot has submitted this change and it was merged.
Change subject: Safer comparison for emails
......................................................................
Safer comparison for emails
Change-Id: Iea1c546e180b1bbdb4ad7fc4e269d85f223b0f27
---
M maintenance/migrateAccount.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/migrateAccount.php b/maintenance/migrateAccount.php
index 48b101d..de2487e 100644
--- a/maintenance/migrateAccount.php
+++ b/maintenance/migrateAccount.php
@@ -114,7 +114,7 @@
){
foreach ( $unattached as $wiki => $local ) {
if (
- $central->getEmail() ==
$local['email']
+ $central->getEmail() ===
$local['email']
&& !is_null(
$local['emailAuthenticated'] )
){
$this->output( "ATTACHING:
$username@$wiki\n" );
@@ -175,7 +175,7 @@
if ( is_null( $email ) ) {
$email = $local['email'];
}
- if ( $local['email'] == $email && !is_null(
$local['emailAuthenticated'] ) ) {
+ if ( $local['email'] === $email && !is_null(
$local['emailAuthenticated'] ) ) {
continue;
}
$emailMatch = false;
--
To view, visit https://gerrit.wikimedia.org/r/144416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1c546e180b1bbdb4ad7fc4e269d85f223b0f27
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Nemo bis <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
