Alexandros Kosiaris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/144695
Change subject: Puppetmaster's logrotate made graceful
......................................................................
Puppetmaster's logrotate made graceful
When the puppmaster logs are rotated everyday a SIGHUP is sent to apache
to force it to reload and start writing to the new files. However that
would kill connections from clients to the puppetmaster causing failed
runs and then nagios checks to whine. Fix this by doing a graceful
restart. This may have the drawback of taking longer for the daemon to
close the old files and open the new ones but not much more than that
Change-Id: I70d59343cf382b3daae2fe650abd843b9e4f64ad
---
M modules/puppetmaster/files/logrotate-passenger
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/95/144695/1
diff --git a/modules/puppetmaster/files/logrotate-passenger
b/modules/puppetmaster/files/logrotate-passenger
index 66eb3cc..d8feb24 100644
--- a/modules/puppetmaster/files/logrotate-passenger
+++ b/modules/puppetmaster/files/logrotate-passenger
@@ -10,6 +10,6 @@
daily
compress
postrotate
- [ ! -f /var/run/apache2.pid ] || kill -HUP `cat
/var/run/apache2.pid`
+ /usr/sbin/apachectl graceful
endscript
}
--
To view, visit https://gerrit.wikimedia.org/r/144695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70d59343cf382b3daae2fe650abd843b9e4f64ad
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
