Dr0ptp4kt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145402
Change subject: WIP: Add Home icon to sidebar.
......................................................................
WIP: Add Home icon to sidebar.
* Users ask for this a lot on Google Play.
* TODO: Need to get icon from UX for Home.
Change-Id: Iab84086916c24c0642a1765bed59422d7e8aea35
---
M wikipedia/res/layout/fragment_navdrawer.xml
M wikipedia/res/values-qq/strings.xml
M wikipedia/res/values/strings.xml
M wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
4 files changed, 30 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/02/145402/1
diff --git a/wikipedia/res/layout/fragment_navdrawer.xml
b/wikipedia/res/layout/fragment_navdrawer.xml
index 590211d..5f95bae 100644
--- a/wikipedia/res/layout/fragment_navdrawer.xml
+++ b/wikipedia/res/layout/fragment_navdrawer.xml
@@ -143,6 +143,29 @@
/>
</LinearLayout>
+ <LinearLayout android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:orientation="horizontal"
+ android:id="@+id/nav_item_home"
+ android:background="@drawable/nav_item_background"
+ >
+ <FrameLayout android:layout_width="24dp"
android:layout_height="24dp"
+ android:layout_margin="12dp"
+ android:layout_gravity="center_vertical">
+ <ImageView android:layout_width="match_parent"
android:layout_height="match_parent"
+ android:src="@android:drawable/ic_menu_directions"
+ android:id="@+id/nav_item_home_icon"
+ android:contentDescription="@null" />
+ </FrameLayout>
+ <TextView
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_gravity="center_vertical"
+ android:text="@string/nav_item_home"
+ style="?android:textAppearanceMediumInverse"
+ />
+ </LinearLayout>
+
<TextView
android:id="@+id/nav_item_zero"
android:layout_width="match_parent"
diff --git a/wikipedia/res/values-qq/strings.xml
b/wikipedia/res/values-qq/strings.xml
index 2bff252..4f7080d 100644
--- a/wikipedia/res/values-qq/strings.xml
+++ b/wikipedia/res/values-qq/strings.xml
@@ -175,6 +175,7 @@
<string name="edit_summary_guide_text">An imperative message, which appears
after starting to save an edit.</string>
<string name="edit_summary_hint">{{Identical|Edit summary}}</string>
<string name="nav_item_random">{{Identical|Random}}</string>
+ <string name="nav_item_home">Text for navigation drawer item to go to the
Main Page</string>
<string name="random_progress">Message shown in progress popup dialog while
waiting for a random article to be fetched</string>
<string name="create_account_account_created_toast">Message shown in a small
toast when account creation is successful.
* {{msg-mw|Accountcreatedtext|message}}</string>
diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml
index 56086be..14293a7 100644
--- a/wikipedia/res/values/strings.xml
+++ b/wikipedia/res/values/strings.xml
@@ -137,6 +137,7 @@
<string name="edit_summary_guide_text">Tell us how you improved this page.
This helps other editors review your edit quickly.</string>
<string name="edit_summary_hint">Edit summary</string>
<string name="nav_item_random">Random</string>
+ <string name="nav_item_home">Home</string>
<string name="random_progress">Fetching random page...</string>
<string name="nav_item_login_benefits">If you Log in, your edits will be
associated with your username and your IP address will not be publicly
visible.</string>
<string name="create_account_account_created_toast">Account
created!</string>
diff --git a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
index 5b91d32..6d3dcd5 100644
--- a/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/NavDrawerFragment.java
@@ -27,7 +27,8 @@
R.id.nav_item_saved_pages,
R.id.nav_item_more,
R.id.nav_item_login,
- R.id.nav_item_random
+ R.id.nav_item_random,
+ R.id.nav_item_home
// We don't actually need R.id.nav_item_zero here because we add
it programmatically
// below, and we don't need an on-tap as of now
};
@@ -149,6 +150,9 @@
case R.id.nav_item_random:
randomHandler.doVisitRandomArticle();
break;
+ case R.id.nav_item_home:
+ WikipediaApp.getInstance().getBus().post(new
RequestMainPageEvent());
+ break;
default:
throw new RuntimeException("Unknown ID clicked!");
}
--
To view, visit https://gerrit.wikimedia.org/r/145402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab84086916c24c0642a1765bed59422d7e8aea35
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
