Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/146307

Change subject: Remove deprecated CentralAuthAutoCreate hook
......................................................................

Remove deprecated CentralAuthAutoCreate hook

Last usage was in TitleBlacklist, removed in I6fc7120f.

Change-Id: If0168ac30ed7e96212da491aa4979c290c239c85
---
M CentralAuthHooks.php
1 file changed, 0 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/07/146307/1

diff --git a/CentralAuthHooks.php b/CentralAuthHooks.php
index d4b29af..bd11459 100644
--- a/CentralAuthHooks.php
+++ b/CentralAuthHooks.php
@@ -904,28 +904,6 @@
                        return false;
                }
 
-               // Give other extensions a chance to stop auto creation, but 
they cannot
-               // change $userName, because CentralAuth expects user names on 
all wikis
-               // are the same.
-               //
-               // * $user (and usually $wgUser) is the half-created User 
object and
-               //   should not be accessed in any way since calling any User 
methods
-               //   in its half-initialised state will give incorrect results.
-               //
-               // * $userName is the new user name
-               //
-               // * $anon is an anonymous user object which can be safely used 
for
-               //   permissions checks.
-               //
-               // NOTE! This hook is deprecated, please use AbortAutoAccount.
-               //
-               if ( !wfRunHooks( 'CentralAuthAutoCreate', array( $user, 
$userName, $anon ) ) ) {
-                       wfDebug( __METHOD__ . ": denied by other extensions\n" 
);
-                       $session['auto-create-blacklist'][] = wfWikiID();
-                       CentralAuthUser::setSession( $session );
-                       return false;
-               }
-
                // Give other extensions a chance to stop auto creation.
                $user->loadDefaults( $userName );
                $abortMessage = '';

-- 
To view, visit https://gerrit.wikimedia.org/r/146307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0168ac30ed7e96212da491aa4979c290c239c85
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to