Trevor Parscal has uploaded a new change for review. https://gerrit.wikimedia.org/r/146909
Change subject: Update VE core submodule to 3ecd4d544b8b27ad6d83ad13a2bc1c234b4834e4 ...................................................................... Update VE core submodule to 3ecd4d544b8b27ad6d83ad13a2bc1c234b4834e4 New changes: 65042de Fix alien test data 83dccbe Add toolbar menu labels to each group for consistency 2e40ef9 Move 'language' tool from the insert to the styling menu, like in VE-MW 6fb21b2 Add toolbar action section to SA demo with keyboard shortcuts tool f3eb000 ve.ui.Toolbar: Optimise onSurfaceViewKeyUp performance eb4e9eb Make sure the document is focused when setting a selection 48584d3 Fixes to getRelativeOffset and getRelativeRange fcc427f [BREAKING CHANGE] Remove generatedContents argument from afterRender 825e4be Documentation fixes in test utils dbbbe0b Unit tests for showSelection 1ba9234 Don't handle up/down on focusableNodes even if backwards a667b87 Remove label from 'insert' menu, and instead use a large plus icon 88885b1 Localisation updates from https://translatewiki.net. 1f3b79f Initialize data first d0cd87e Localisation updates from https://translatewiki.net. 3ecd4d5 Update OOjs UI to v0.1.0-pre (54a54f1cb6) Other changes: * Add context to toolbar (used to be in a local overlay) Change-Id: Ieafe79961e6c29b69b40bc72719817914cff792d --- M lib/ve M modules/ve-mw/init/styles/ve.init.mw.MobileViewTarget.css M modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js 3 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/09/146909/1 diff --git a/lib/ve b/lib/ve index f2277ea..3ecd4d5 160000 --- a/lib/ve +++ b/lib/ve -Subproject commit f2277eaea1be3233de41aeb1e8e797ca0bff8092 +Subproject commit 3ecd4d544b8b27ad6d83ad13a2bc1c234b4834e4 diff --git a/modules/ve-mw/init/styles/ve.init.mw.MobileViewTarget.css b/modules/ve-mw/init/styles/ve.init.mw.MobileViewTarget.css index 2716dd4..b95e19d 100644 --- a/modules/ve-mw/init/styles/ve.init.mw.MobileViewTarget.css +++ b/modules/ve-mw/init/styles/ve.init.mw.MobileViewTarget.css @@ -9,3 +9,11 @@ /* enough to cover .overlay-header-container with z-index: 5 */ z-index: 6; } + +.ve-ui-mobileContext { + position: absolute; + left: 0; + right: 0; + margin-top: 1px; + z-index: 4; +} \ No newline at end of file diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js b/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js index 79d38b0..b68ee6b 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.MobileViewTarget.js @@ -96,5 +96,6 @@ // FIXME shouldn't be using viewPageTarget styles .addClass( 've-init-mw-viewPageTarget-toolbar' ) // Move the toolbar to the overlay header - .appendTo( '.overlay-header > .toolbar' ); + .appendTo( '.overlay-header > .toolbar' ) + .append( this.surface.getContext().$element ); }; -- To view, visit https://gerrit.wikimedia.org/r/146909 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieafe79961e6c29b69b40bc72719817914cff792d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
