[MediaWiki-commits] [Gerrit] Remove is*ArrowKey functions - change (VisualEditor/VisualEditor)

[Esanders (Code Review)]

Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/147085

Change subject: Remove is*ArrowKey functions
......................................................................

Remove is*ArrowKey functions

Three functions only used once.

Change-Id: Id949ac1e9492f04df6369bc09238bb0852b3e3bb
---
M modules/ve/ce/ve.ce.Surface.js
M modules/ve/ce/ve.ce.js
M modules/ve/test/ce/ve.ce.test.js
3 files changed, 1 insertion(+), 50 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/85/147085/1

diff --git a/modules/ve/ce/ve.ce.Surface.js b/modules/ve/ce/ve.ce.Surface.js
index e28f961..957b598 100644
--- a/modules/ve/ce/ve.ce.Surface.js
+++ b/modules/ve/ce/ve.ce.Surface.js
@@ -733,7 +733,7 @@
                                this.selecting = true;
                                this.emit( 'selectionStart' );
                        }
-                       if ( ve.ce.isLeftOrRightArrowKey( e.keyCode ) ) {
+                       if ( e.keyCode === OO.ui.Keys.LEFT || e.keyCode === 
OO.ui.Keys.RIGHT ) {
                                this.handleLeftOrRightArrowKey( e );
                        } else {
                                this.handleUpOrDownArrowKey( e );
diff --git a/modules/ve/ce/ve.ce.js b/modules/ve/ce/ve.ce.js
index 869cdb2..2b430d8 100644
--- a/modules/ve/ce/ve.ce.js
+++ b/modules/ve/ce/ve.ce.js
@@ -296,33 +296,6 @@
 };
 
 /**
- * Check if the key code represents a left or right arrow key
- * @param {number} keyCode Key code
- * @returns {boolean} Key code represents a left or right arrow key
- */
-ve.ce.isLeftOrRightArrowKey = function ( keyCode ) {
-       return keyCode === OO.ui.Keys.LEFT || keyCode === OO.ui.Keys.RIGHT;
-};
-
-/**
- * Check if the key code represents an up or down arrow key
- * @param {number} keyCode Key code
- * @returns {boolean} Key code represents an up or down arrow key
- */
-ve.ce.isUpOrDownArrowKey = function ( keyCode ) {
-       return keyCode === OO.ui.Keys.UP || keyCode === OO.ui.Keys.DOWN;
-};
-
-/**
- * Check if the key code represents an arrow key
- * @param {number} keyCode Key code
- * @returns {boolean} Key code represents an arrow key
- */
-ve.ce.isArrowKey = function ( keyCode ) {
-       return ve.ce.isLeftOrRightArrowKey( keyCode ) || 
ve.ce.isUpOrDownArrowKey( keyCode );
-};
-
-/**
  * Check if keyboard shortcut modifier key is pressed.
  *
  * @method
diff --git a/modules/ve/test/ce/ve.ce.test.js b/modules/ve/test/ce/ve.ce.test.js
index 7db7df5..7171ebe 100644
--- a/modules/ve/test/ce/ve.ce.test.js
+++ b/modules/ve/test/ce/ve.ce.test.js
@@ -200,28 +200,6 @@
 
 // TODO: ve.ce.getOffsetOfSlug
 
-QUnit.test( 'isLeftOrRightArrowKey', 4, function ( assert ) {
-       assert.equal( ve.ce.isLeftOrRightArrowKey( OO.ui.Keys.LEFT ), true, 
'Left' );
-       assert.equal( ve.ce.isLeftOrRightArrowKey( OO.ui.Keys.RIGHT ), true, 
'Right' );
-       assert.equal( ve.ce.isLeftOrRightArrowKey( OO.ui.Keys.UP ), false, 'Up' 
);
-       assert.equal( ve.ce.isLeftOrRightArrowKey( OO.ui.Keys.DOWN ), false, 
'Down' );
-} );
-
-QUnit.test( 'isUpOrDownArrowKey', 4, function ( assert ) {
-       assert.equal( ve.ce.isUpOrDownArrowKey( OO.ui.Keys.LEFT ), false, 
'Left' );
-       assert.equal( ve.ce.isUpOrDownArrowKey( OO.ui.Keys.RIGHT ), false, 
'Right' );
-       assert.equal( ve.ce.isUpOrDownArrowKey( OO.ui.Keys.UP ), true, 'Up' );
-       assert.equal( ve.ce.isUpOrDownArrowKey( OO.ui.Keys.DOWN ), true, 'Down' 
);
-} );
-
-QUnit.test( 'isArrowKey', 5, function ( assert ) {
-       assert.equal( ve.ce.isArrowKey( OO.ui.Keys.LEFT ), true, 'Left' );
-       assert.equal( ve.ce.isArrowKey( OO.ui.Keys.RIGHT ), true, 'Right' );
-       assert.equal( ve.ce.isArrowKey( OO.ui.Keys.UP ), true, 'Up' );
-       assert.equal( ve.ce.isArrowKey( OO.ui.Keys.DOWN ), true, 'Down' );
-       assert.equal( ve.ce.isArrowKey( OO.ui.Keys.ENTER ), false, 'Enter' );
-} );
-
 QUnit.test( 'isShortcutKey', 3, function ( assert ) {
        assert.equal( ve.ce.isShortcutKey( { 'ctrlKey': true } ), true, 
'ctrlKey' );
        assert.equal( ve.ce.isShortcutKey( { 'metaKey': true } ), true, 
'metaKey' );

-- 
To view, visit https://gerrit.wikimedia.org/r/147085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id949ac1e9492f04df6369bc09238bb0852b3e3bb
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits