jenkins-bot has submitted this change and it was merged.
Change subject: Dialog title alignment and iframe size fixes
......................................................................
Dialog title alignment and iframe size fixes
Changes:
* Make all window iframes (not just modal ones) expand to fill their
parent div, which is where sizing is actually applied
* Fix broken selector (can't start with ">")
* Reduce padding around ProcessDialog title to correct alignment
Change-Id: I7cec1cf115bd2ae39d9fe92cdc02db4ad973415d
---
M src/styles/Window.less
M src/styles/WindowManager.less
M src/themes/apex/dialogs/ProcessDialog.less
3 files changed, 2 insertions(+), 7 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/styles/Window.less b/src/styles/Window.less
index 62a33db..ca384f8 100644
--- a/src/styles/Window.less
+++ b/src/styles/Window.less
@@ -3,7 +3,7 @@
.oo-ui-window {
line-height: 1em;
- > &-frame {
+ & > &-frame {
.oo-ui-box-sizing(border-box);
> .oo-ui-frame {
diff --git a/src/styles/WindowManager.less b/src/styles/WindowManager.less
index b04b55a..1232a63 100644
--- a/src/styles/WindowManager.less
+++ b/src/styles/WindowManager.less
@@ -22,11 +22,6 @@
overflow: hidden;
max-width: 100%;
max-height: 100%;
-
- .oo-ui-frame {
- width: 100%;
- height: 100%;
- }
}
}
}
diff --git a/src/themes/apex/dialogs/ProcessDialog.less
b/src/themes/apex/dialogs/ProcessDialog.less
index 91e0356..6ac3646 100644
--- a/src/themes/apex/dialogs/ProcessDialog.less
+++ b/src/themes/apex/dialogs/ProcessDialog.less
@@ -17,7 +17,7 @@
}
&-location {
- padding: 0.75em 0;
+ padding: 0.25em 0;
height: 1.9em;
cursor: default;
text-align: center;
--
To view, visit https://gerrit.wikimedia.org/r/147179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cec1cf115bd2ae39d9fe92cdc02db4ad973415d
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
