jenkins-bot has submitted this change and it was merged.
Change subject: Fix NPE from editing.EditHandler.onMessage
......................................................................
Fix NPE from editing.EditHandler.onMessage
If fragment is not added then we don't want to do those actions.
Bug: 68171
Change-Id: If322d0408d02279b58b64cebcea2ce89b0c40e54
---
M wikipedia/src/main/java/org/wikipedia/editing/EditHandler.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Yuvipanda: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/src/main/java/org/wikipedia/editing/EditHandler.java
b/wikipedia/src/main/java/org/wikipedia/editing/EditHandler.java
index b1f5148..a99c3d9 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditHandler.java
@@ -51,14 +51,15 @@
}
/**
- * Variable indicating wehther the current page was refreshed (by clicking
on edit
- * when it was a saved page and chosing to refresh.
- *
- * Used for accuarat eventlogging
+ * Variable indicating whether the current page was refreshed (by clicking
on edit
+ * when it was a saved page and choosing to refresh. Used for accurate
event logging
*/
private boolean wasRefreshed = false;
@Override
public void onMessage(String messageType, JSONObject messagePayload) {
+ if (!fragment.isAdded()) {
+ return;
+ }
if (messageType.equals("editSectionClicked")) {
final SavedPagesFunnel savedPagesFunnel =
WikipediaApp.getInstance().getFunnelManager().getSavedPagesFunnel(currentPage.getTitle().getSite());
if (fragment.getHistoryEntry().getSource() ==
HistoryEntry.SOURCE_SAVED_PAGE) {
--
To view, visit https://gerrit.wikimedia.org/r/147165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If322d0408d02279b58b64cebcea2ce89b0c40e54
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
