Bsitu has uploaded a new change for review. https://gerrit.wikimedia.org/r/148011
Change subject: Formatter Fix for related Echo change ...................................................................... Formatter Fix for related Echo change Related: https://gerrit.wikimedia.org/r/#/c/147369/ Change-Id: I5dc82a66f3aa289da1ff1a2f1ccd2db548b6bb66 --- M includes/Notifications/Formatter.php 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/11/148011/1 diff --git a/includes/Notifications/Formatter.php b/includes/Notifications/Formatter.php index 93ff1ff..02d99b9 100644 --- a/includes/Notifications/Formatter.php +++ b/includes/Notifications/Formatter.php @@ -158,7 +158,13 @@ protected function getFirstUnreadPostId( $event, $user ) { $data = $this->getBundleLastRawData( $event, $user ); if ( $data ) { - $extra = $data->event_extra; + // Remove the check once the corresponding Echo patch is + // merged, $data should be always an instance of EchoEvent + if ( $data instanceof \EchoEvent ) { + $extra = $data->getExtra(); + } else { + $extra = $data->event_extra; + } if ( isset( $extra['post-id'] ) ) { return $extra['post-id']; } -- To view, visit https://gerrit.wikimedia.org/r/148011 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5dc82a66f3aa289da1ff1a2f1ccd2db548b6bb66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Bsitu <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
