jenkins-bot has submitted this change and it was merged.
Change subject: Swap MessageCache::get closure to global function to fix
segfault
......................................................................
Swap MessageCache::get closure to global function to fix segfault
Stopping Database Dumps from running
Change-Id: I1b34716cd981acc72ab4f3ad0036620fb1d56a58
(cherry picked from commit 51cef005cdf6d477fe95149490aa9396231f91df)
---
M WikimediaMessages.php
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikimediaMessages.php b/WikimediaMessages.php
index d0a2466..a6245db 100644
--- a/WikimediaMessages.php
+++ b/WikimediaMessages.php
@@ -107,12 +107,21 @@
return true;
};
+$wgHooks['MessageCache::get'][] = 'wfWikimediaMessagesMessageCacheGet';
+
/**
* When core requests certain messages, change the key to a Wikimedia version.
*
+ * @note Don't make this a closure, it causes the Database Dumps to fail.
+ * See https://bugs.php.net/bug.php?id=52144
+ *
+ * mwscript getSlaveServer.php --wiki='dewiki' --group=dump --globals
+ * print_r( $GLOBALS['wgHooks']['MessageCache::get'] );
+ *
* @param String &$lcKey message key to check and possibly convert
+ * @return bool
*/
-$wgHooks['MessageCache::get'][] = function( &$lcKey ) {
+function wfWikimediaMessagesMessageCacheGet( &$lcKey ) {
global $wgLanguageCode;
static $keys = array(
--
To view, visit https://gerrit.wikimedia.org/r/148515
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b34716cd981acc72ab4f3ad0036620fb1d56a58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: wmf/1.24wmf13
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
