Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148654
Change subject: Make naming in SiteLinkTargetProviderTest more clear
......................................................................
Make naming in SiteLinkTargetProviderTest more clear
giving more descriptive (example) names makes the test cases
and expected results a lot more clear, vs. site1, site2 ...
Change-Id: I54f301c1a1f6f3cb705ee5863c7bcf552fcfda7e
---
M repo/tests/phpunit/includes/api/SiteLinkTargetProviderTest.php
1 file changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/148654/1
diff --git a/repo/tests/phpunit/includes/api/SiteLinkTargetProviderTest.php
b/repo/tests/phpunit/includes/api/SiteLinkTargetProviderTest.php
index e0a1a01..0f17cba 100644
--- a/repo/tests/phpunit/includes/api/SiteLinkTargetProviderTest.php
+++ b/repo/tests/phpunit/includes/api/SiteLinkTargetProviderTest.php
@@ -34,27 +34,27 @@
public static function provideExpected() {
return array(
- //groupsToGet, specialGroups, siteIdsExpected
- array( array( 'foo' ), array(), array( 'site1', 'site2'
) ),
- array( array( 'bar' ), array(), array( 'site3' ) ),
- array( array( 'baz' ), array(), array( 'site4' ) ),
+ // groupsToGet, specialGroups, siteIdsExpected
+ array( array( 'wikipedia' ), array(), array( 'eswiki',
'dawiki' ) ),
+ array( array( 'species' ), array(), array(
'specieswiki' ) ),
+ array( array( 'wikiquote' ), array(), array(
'eswikiquote' ) ),
array( array( 'qwerty' ), array(), array() ),
- array( array( 'foo', 'bar' ), array(), array( 'site1',
'site2', 'site3' ) ),
- array( array( 'foo', 'baz' ), array(), array( 'site1',
'site2', 'site4' ) ),
- array( array( 'special' ), array( 'bar' ), array(
'site3' ) ),
- array( array( 'foo' ), array( 'bar' ), array( 'site1',
'site2' ) ),
- array( array( 'special', 'foo' ), array( 'bar', 'baz'
), array( 'site1', 'site2', 'site3', 'site4' ) ),
- array( array(), array( 'foo' ), array() ),
+ array( array( 'wikipedia', 'species' ), array(), array(
'eswiki', 'dawiki', 'specieswiki' ) ),
+ array( array( 'wikipedia', 'wikiquote' ), array(),
array( 'eswiki', 'dawiki', 'eswikiquote' ) ),
+ array( array( 'special' ), array( 'species' ), array(
'specieswiki' ) ),
+ array( array( 'wikipedia' ), array( 'species' ), array(
'eswiki', 'dawiki' ) ),
+ array( array( 'special', 'wikipedia' ), array(
'species', 'wikiquote' ), array( 'eswiki', 'dawiki', 'specieswiki',
'eswikiquote' ) ),
+ array( array(), array( 'wikipedia' ), array() ),
array( array(), array(), array() ),
);
}
protected function getSiteList() {
$siteList = new SiteList();
- $siteList->append( $this->getMockSite( 'site1', 'foo' ) );
- $siteList->append( $this->getMockSite( 'site2', 'foo' ) );
- $siteList->append( $this->getMockSite( 'site3', 'bar' ) );
- $siteList->append( $this->getMockSite( 'site4', 'baz' ) );
+ $siteList->append( $this->getMockSite( 'eswiki', 'wikipedia' )
);
+ $siteList->append( $this->getMockSite( 'dawiki', 'wikipedia' )
);
+ $siteList->append( $this->getMockSite( 'specieswiki', 'species'
) );
+ $siteList->append( $this->getMockSite( 'eswikiquote',
'wikiquote' ) );
return $siteList;
}
--
To view, visit https://gerrit.wikimedia.org/r/148654
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54f301c1a1f6f3cb705ee5863c7bcf552fcfda7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
