Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/148655
to review the following change.
Change subject: Prefer '!=' over '<>' in HiveQL
......................................................................
Prefer '!=' over '<>' in HiveQL
Change-Id: I70f0a3d15d3f1896b37ca93320ee3d65596bdebd
---
M HACKING.md
M oozie/webrequest/partition/add/extract_faulty_hosts.hql
2 files changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery
refs/changes/55/148655/1
diff --git a/HACKING.md b/HACKING.md
index fde5488..4242554 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -42,4 +42,6 @@
* Use 4 spaces to indent files.
-* There is no rule on vertical alignment.
\ No newline at end of file
+* There is no rule on vertical alignment.
+
+* In HiveQL, we prefe ```!=``` over ```<>```.
diff --git a/oozie/webrequest/partition/add/extract_faulty_hosts.hql
b/oozie/webrequest/partition/add/extract_faulty_hosts.hql
index 736dc69..34281ef 100644
--- a/oozie/webrequest/partition/add/extract_faulty_hosts.hql
+++ b/oozie/webrequest/partition/add/extract_faulty_hosts.hql
@@ -46,11 +46,11 @@
INSERT OVERWRITE DIRECTORY '${target}'
SELECT * FROM ${table} WHERE
(
- count_duplicate <> 0 -- Host has duplicates
+ count_duplicate != 0 -- Host has duplicates
OR
- count_different <> 0 -- Host has duplicates or holes
+ count_different != 0 -- Host has duplicates or holes
OR
- count_null_sequence <> 0 -- Host has NULL sequence numbers
+ count_null_sequence != 0 -- Host has NULL sequence numbers
) AND
webrequest_source='${webrequest_source}' AND
year=${year} AND month=${month} AND day=${day} AND hour=${hour}
--
To view, visit https://gerrit.wikimedia.org/r/148655
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70f0a3d15d3f1896b37ca93320ee3d65596bdebd
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
