jenkins-bot has submitted this change and it was merged.

Change subject: Add a space to the comment node for selection highlighting
......................................................................


Add a space to the comment node for selection highlighting

Change-Id: I82ff9329d7f04ad9068408c17f1545d4071d6360
---
M modules/ve/ce/nodes/ve.ce.CommentNode.js
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ce/nodes/ve.ce.CommentNode.js 
b/modules/ve/ce/nodes/ve.ce.CommentNode.js
index 1dc58b5..440eb6a 100644
--- a/modules/ve/ce/nodes/ve.ce.CommentNode.js
+++ b/modules/ve/ce/nodes/ve.ce.CommentNode.js
@@ -22,7 +22,9 @@
 
        // DOM changes
        this.$element
-               .addClass( 've-ce-commentNode oo-ui-indicator-comment' );
+               .addClass( 've-ce-commentNode oo-ui-indicator-comment' )
+               // Add em space for selection highlighting
+               .text( '\u2003' );
 
        // Mixin constructors
        ve.ce.FocusableNode.call( this, this.$element, config );

-- 
To view, visit https://gerrit.wikimedia.org/r/148964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82ff9329d7f04ad9068408c17f1545d4071d6360
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to