Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/148985

Change subject: Don't show wikibase recent changes / watchlist pref if feature 
disabled
......................................................................

Don't show wikibase recent changes / watchlist pref if feature disabled

Bug: 68463
Change-Id: I488f3139bab48196140036a28497eb39022d5c98
---
M client/WikibaseClient.hooks.php
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/85/148985/1

diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 26372b4..4796e2c 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -734,6 +734,12 @@
         * @return bool
         */
        public static function onGetPreferences( User $user, array &$prefs ) {
+               $settings = WikibaseClient::getDefaultInstance()->getSettings();
+
+               if ( !$settings->getSetting( 'showExternalRecentChanges' ) ) {
+                       return true;
+               }
+
                $prefs['rcshowwikidata'] = array(
                        'type' => 'toggle',
                        'label-message' => 'wikibase-rc-show-wikidata-pref',

-- 
To view, visit https://gerrit.wikimedia.org/r/148985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I488f3139bab48196140036a28497eb39022d5c98
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to