Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149004
Change subject: Add @todo in LanguageAwareRenderer regarding PropertyId
resolving
......................................................................
Add @todo in LanguageAwareRenderer regarding PropertyId resolving
Change-Id: I56d4339c81de34294255d3651fafdca258d444eb
---
M client/includes/DataAccess/PropertyParserFunction/LanguageAwareRenderer.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/04/149004/1
diff --git
a/client/includes/DataAccess/PropertyParserFunction/LanguageAwareRenderer.php
b/client/includes/DataAccess/PropertyParserFunction/LanguageAwareRenderer.php
index 5163b9a..6164de1 100644
---
a/client/includes/DataAccess/PropertyParserFunction/LanguageAwareRenderer.php
+++
b/client/includes/DataAccess/PropertyParserFunction/LanguageAwareRenderer.php
@@ -57,6 +57,7 @@
*/
public function render( EntityId $entityId, $propertyLabelOrId ) {
try {
+ // @todo have the $propertyId resolved before passing
into here
$propertyId =
$this->propertyIdResolver->resolvePropertyId(
$propertyLabelOrId,
$this->language->getCode()
--
To view, visit https://gerrit.wikimedia.org/r/149004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56d4339c81de34294255d3651fafdca258d444eb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
