Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149227
Change subject: DM 1.0 compat: do not use EntityId constructor
......................................................................
DM 1.0 compat: do not use EntityId constructor
Change-Id: I6bc643a6ed3dcb956b7cb8fb6e14160c2d53bd0e
---
M repo/includes/store/sql/EntityPerPageTable.php
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/27/149227/1
diff --git a/repo/includes/store/sql/EntityPerPageTable.php
b/repo/includes/store/sql/EntityPerPageTable.php
index f22d250..d6e1586 100644
--- a/repo/includes/store/sql/EntityPerPageTable.php
+++ b/repo/includes/store/sql/EntityPerPageTable.php
@@ -3,8 +3,8 @@
namespace Wikibase;
use InvalidArgumentException;
-use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\ItemId;
+use Wikibase\DataModel\LegacyIdInterpreter;
/**
* Represents a lookup database table that make the link between entities and
pages.
@@ -22,7 +22,7 @@
class EntityPerPageTable implements EntityPerPage {
/**
- * @var BasicEntityIdParser
+ * @var LegacyIdInterpreter
*/
private $idParser;
@@ -41,7 +41,7 @@
throw new InvalidArgumentException(
'$useRedirectTargetColumn must be true or false' );
}
- $this->idParser = new BasicEntityIdParser();
+ $this->idParser = new LegacyIdInterpreter();
$this->useRedirectTargetColumn = $useRedirectTargetColumn;
}
@@ -253,8 +253,8 @@
$entities = array();
foreach ( $rows as $row ) {
- $id = new EntityId( $row->entity_type,
(int)$row->entity_id );
- $entities[] = $this->idParser->parse(
$id->getSerialization() );
+ // FIXME: this only works for items and properties
+ $entities[] = $this->idParser->newIdFromTypeAndNumber(
$row->entity_type, (int)$row->entity_id );
}
return $entities;
--
To view, visit https://gerrit.wikimedia.org/r/149227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bc643a6ed3dcb956b7cb8fb6e14160c2d53bd0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
