Jeroen De Dauw has submitted this change and it was merged.
Change subject: DM 1.0 compat: do not use return value of
SiteLinkList::addNewSiteLink
......................................................................
DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink
Change-Id: I085e9b290bcaeb0ae68d3fe169d27740ebe8ce92
---
M client/tests/phpunit/includes/LangLinkHandlerTest.php
1 file changed, 10 insertions(+), 10 deletions(-)
Approvals:
Jeroen De Dauw: Verified; Looks good to me, approved
diff --git a/client/tests/phpunit/includes/LangLinkHandlerTest.php
b/client/tests/phpunit/includes/LangLinkHandlerTest.php
index 2b390b1..2744b76 100644
--- a/client/tests/phpunit/includes/LangLinkHandlerTest.php
+++ b/client/tests/phpunit/includes/LangLinkHandlerTest.php
@@ -33,21 +33,21 @@
$item = Item::newEmpty();
$item->setId( 1 );
$item->setLabel( 'en', 'Foo' );
- $item->getSiteLinkList()
- ->addNewSiteLink( 'dewiki', 'Foo de' )
- ->addNewSiteLink( 'enwiki', 'Foo en' )
- ->addNewSiteLink( 'srwiki', 'Foo sr' )
- ->addNewSiteLink( 'dewiktionary', 'Foo de word' )
- ->addNewSiteLink( 'enwiktionary', 'Foo en word' );
+ $links = $item->getSiteLinkList();
+ $links->addNewSiteLink( 'dewiki', 'Foo de' );
+ $links->addNewSiteLink( 'enwiki', 'Foo en' );
+ $links->addNewSiteLink( 'srwiki', 'Foo sr' );
+ $links->addNewSiteLink( 'dewiktionary', 'Foo de word' );
+ $links->addNewSiteLink( 'enwiktionary', 'Foo en word' );
$items[] = $item;
$item = Item::newEmpty();
$item->setId( 2 );
$item->setLabel( 'en', 'Talk:Foo' );
- $item->getSiteLinkList()
- ->addNewSiteLink( 'dewiki', 'Talk:Foo de' )
- ->addNewSiteLink( 'enwiki', 'Talk:Foo en' )
- ->addNewSiteLink( 'srwiki', 'Talk:Foo sr' );
+ $links = $item->getSiteLinkList();
+ $links->addNewSiteLink( 'dewiki', 'Talk:Foo de' );
+ $links->addNewSiteLink( 'enwiki', 'Talk:Foo en' );
+ $links->addNewSiteLink( 'srwiki', 'Talk:Foo sr' );
$items[] = $item;
return $items;
--
To view, visit https://gerrit.wikimedia.org/r/149244
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I085e9b290bcaeb0ae68d3fe169d27740ebe8ce92
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
