jenkins-bot has submitted this change and it was merged.
Change subject: Add DM 1.0 TODOs in WikibaseRepoTest
......................................................................
Add DM 1.0 TODOs in WikibaseRepoTest
Change-Id: Ibd7488934eafd66de8d25c1c87614b143ffc16f5
---
M repo/tests/phpunit/includes/WikibaseRepoTest.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/WikibaseRepoTest.php
b/repo/tests/phpunit/includes/WikibaseRepoTest.php
index a11cae4..add8699 100644
--- a/repo/tests/phpunit/includes/WikibaseRepoTest.php
+++ b/repo/tests/phpunit/includes/WikibaseRepoTest.php
@@ -159,6 +159,7 @@
$this->assertInstanceOf(
'Wikibase\Lib\Changes\EntityChangeFactory', $factory );
}
+ // TODO: DM 1.0 blocker, this uses Entity::toArray
public function testGetEntityContentDataCodec_legacy() {
$item = Item::newEmpty();
$item->setLabel( 'en', 'Hello' );
@@ -174,6 +175,7 @@
$this->assertEquals( $item->toArray(), $data );
}
+ // TODO: DM 1.0 blocker, this uses Entity::toArray
public function testGetInternalEntitySerializer_legacy() {
$item = Item::newEmpty();
$item->setLabel( 'en', 'Hello' );
@@ -188,6 +190,7 @@
$this->assertEquals( $item->toArray(), $data );
}
+ // TODO: DM 1.0 blocker, this uses Claim::toArray
public function testGetInternalClaimSerializer_legacy() {
$claim = new Statement( new PropertyNoValueSnak( 42 ) );
$claim->setGuid( 'kittens' );
--
To view, visit https://gerrit.wikimedia.org/r/149234
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd7488934eafd66de8d25c1c87614b143ffc16f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
