[MediaWiki-commits] [Gerrit] Add missing type hints - change (mediawiki...Wikibase)

[WMDE]

Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/149291

Change subject: Add missing type hints
......................................................................

Add missing type hints

Change-Id: I1cb04a13d84ca90aec18d557bf5b8e48299c3d99
---
M client/tests/phpunit/includes/ReferencedPagesFinderTest.php
M lib/includes/changes/EntityChangeFactory.php
2 files changed, 28 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/91/149291/1

diff --git a/client/tests/phpunit/includes/ReferencedPagesFinderTest.php 
b/client/tests/phpunit/includes/ReferencedPagesFinderTest.php
index f8b5f6a..4296102 100644
--- a/client/tests/phpunit/includes/ReferencedPagesFinderTest.php
+++ b/client/tests/phpunit/includes/ReferencedPagesFinderTest.php
@@ -3,9 +3,9 @@
 namespace Wikibase\Test;
 
 use Title;
+use Wikibase\DataModel\Entity\Item;
 use Wikibase\DataModel\Entity\ItemId;
 use Wikibase\DataModel\SiteLink;
-use Wikibase\DataModel\Entity\Item;
 use Wikibase\ItemChange;
 use Wikibase\ReferencedPagesFinder;
 
@@ -25,7 +25,7 @@
        /**
         * @dataProvider getPagesProvider
         */
-       public function testGetPages( $expected, $usage, $change, $message ) {
+       public function testGetPages( array $expected, array $usage, ItemChange 
$change, $message ) {
                $itemUsageIndex = $this->getMockBuilder( 
'\Wikibase\ItemUsageIndex' )
                                                        
->disableOriginalConstructor()->getMock();
 
@@ -124,7 +124,7 @@
                                $this->getItemWithSiteLinks( array( 'enwiki' => 
'Rome' ) ),
                                $this->getItemWithSiteLinks( array(
                                        'enwiki' => 'Rome',
-                                       'itwiki' => 'Roma'
+                                       'itwiki' => 'Roma',
                                ) )
                        ),
                        'added site link on connected item'
@@ -168,6 +168,9 @@
                return $cases;
        }
 
+       /**
+        * @return Item
+        */
        private function getEmptyItem() {
                $item = Item::newEmpty();
                $item->setId( 2 );
@@ -175,7 +178,12 @@
                return $item->copy();
        }
 
-       private function getItemWithSiteLinks( $links ) {
+       /**
+        * @param string[] $links
+        *
+        * @return Item
+        */
+       private function getItemWithSiteLinks( array $links ) {
                $item = $this->getEmptyItem();
 
                foreach( $links as $siteId => $page ) {
@@ -187,16 +195,28 @@
                return $item->copy();
        }
 
-       private function getItemWithLabel( $lang, $label ) {
+       /**
+        * @param string $languageCode
+        * @param string $label
+        *
+        * @return Item
+        */
+       private function getItemWithLabel( $languageCode, $label ) {
                $item = $this->getEmptyItem();
-               $item->setLabel( $lang, $label );
+               $item->setLabel( $languageCode, $label );
 
                return $item;
        }
 
+       /**
+        * @param Title[] $titles
+        *
+        * @return string[]
+        */
        private function getPrefixedTitles( array $titles ) {
                return array_map( function( Title $title ) {
                        return $title->getPrefixedText();
                }, $titles );
        }
+
 }
diff --git a/lib/includes/changes/EntityChangeFactory.php 
b/lib/includes/changes/EntityChangeFactory.php
index c2eac88..ec39d86 100644
--- a/lib/includes/changes/EntityChangeFactory.php
+++ b/lib/includes/changes/EntityChangeFactory.php
@@ -5,10 +5,10 @@
 use InvalidArgumentException;
 use MWException;
 use Wikibase\ChangesTable;
-use Wikibase\Entity;
+use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityId;
 use Wikibase\EntityChange;
 use Wikibase\EntityFactory;
-use Wikibase\EntityId;
 
 /**
  * Factory for EntityChange objects

-- 
To view, visit https://gerrit.wikimedia.org/r/149291
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cb04a13d84ca90aec18d557bf5b8e48299c3d99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits