Hello Milimetric,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/149298
to review the following change.
Change subject: Document choice of constant in connection pool test
......................................................................
Document choice of constant in connection pool test
Change-Id: Ie8864b48db1bb0d71e66f25bb2edadadf9d4e8a7
---
M tests/manual/connection_pool_configuration.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikimetrics
refs/changes/98/149298/1
diff --git a/tests/manual/connection_pool_configuration.py
b/tests/manual/connection_pool_configuration.py
index c9718c7..12b2c26 100644
--- a/tests/manual/connection_pool_configuration.py
+++ b/tests/manual/connection_pool_configuration.py
@@ -12,6 +12,9 @@
@raises(TimeoutError)
def test_pool_size_can_be_exceeded(self):
+ # The 11 in the following statement is 10 (default for
+ # max_overflow) + 1. So this is the lowest value for which we
+ # expect the connection to fail.
pool_size = db.config['MEDIAWIKI_POOL_SIZE'] + 11
self.sessions = [
db.get_mw_session(mediawiki_project)
--
To view, visit https://gerrit.wikimedia.org/r/149298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8864b48db1bb0d71e66f25bb2edadadf9d4e8a7
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikimetrics
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
