jenkins-bot has submitted this change and it was merged.
Change subject: Fixing height of image in mobile media viewer
......................................................................
Fixing height of image in mobile media viewer
Changing a .height() to an .outerHeight().
Change-Id: Id567fbe2b3d6a5ebda0c2be4726d2edbfd2b4eb2
---
M javascripts/modules/mediaViewer/ImageOverlay.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/mediaViewer/ImageOverlay.js
b/javascripts/modules/mediaViewer/ImageOverlay.js
index 493cedd..2efa4bc 100644
--- a/javascripts/modules/mediaViewer/ImageOverlay.js
+++ b/javascripts/modules/mediaViewer/ImageOverlay.js
@@ -59,7 +59,7 @@
},
_positionImage: function() {
- var detailsHeight = this.$( '.details' ).height(),
+ var detailsHeight = this.$( '.details' ).outerHeight(),
windowWidth = $( window ).width(),
windowHeight = $( window ).height() -
detailsHeight,
windowRatio = windowWidth / windowHeight,
--
To view, visit https://gerrit.wikimedia.org/r/149221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id567fbe2b3d6a5ebda0c2be4726d2edbfd2b4eb2
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
