Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149924
Change subject: Remove unused CSS classes
......................................................................
Remove unused CSS classes
By searching for CSS classes that don't exist in the code.
In some cases the classes were used but had been renamed.
Change-Id: I76442a632c18d2133cdf78c4555da149c0a7888c
---
M VisualEditor.php
M modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
M modules/ve-mw/ce/styles/nodes/ve.ce.MWBlockImageNode.css
M modules/ve-mw/ce/styles/nodes/ve.ce.MWInlineImageNode.css
M modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
D modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.Icons.css
M modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
M modules/ve-mw/init/ve.init.mw.Target.js
M modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWMetaDialog.css
M modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
M modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryPopupWidget.css
M modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaResultWidget.css
13 files changed, 23 insertions(+), 99 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/24/149924/1
diff --git a/VisualEditor.php b/VisualEditor.php
index 93a80fc..e17b7b7 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -137,13 +137,6 @@
'targets' => array( 'desktop', 'mobile' ),
),
- 'ext.visualEditor.viewPageTarget.icons' =>
$wgVisualEditorResourceTemplate + array(
- 'styles' => array(
-
'modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.Icons.css',
- ),
- 'targets' => array( 'desktop', 'mobile' ),
- ),
-
'ext.visualEditor.viewPageTarget.init' =>
$wgVisualEditorResourceTemplate + array(
'scripts' =>
'modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js',
'styles' =>
'modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.init.css',
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
index 9a0c622..dab32fb 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWBlockImageNode.js
@@ -48,6 +48,12 @@
this.$figure = this.$( '<figure>' )
.appendTo( this.$element )
.append( this.$a )
+ // The following classes can be used here:
+ // ve-ce-mwBlockImageNode-type-thumb
+ // ve-ce-mwBlockImageNode-type-frame
+ // ve-ce-mwBlockImageNode-type-frameless
+ // ve-ce-mwBlockImageNode-type-border
+ // ve-ce-mwBlockImageNode-type-none
.addClass( 've-ce-mwBlockImageNode
ve-ce-mwBlockImageNode-type-' + type )
// 'typeof' should appear with the proper Parsoid-generated
// type. The model deals with converting it
diff --git a/modules/ve-mw/ce/styles/nodes/ve.ce.MWBlockImageNode.css
b/modules/ve-mw/ce/styles/nodes/ve.ce.MWBlockImageNode.css
index 974ed82..0b0921e 100644
--- a/modules/ve-mw/ce/styles/nodes/ve.ce.MWBlockImageNode.css
+++ b/modules/ve-mw/ce/styles/nodes/ve.ce.MWBlockImageNode.css
@@ -6,16 +6,6 @@
*/
/*csslint regex-selectors:false, overqualified-elements:false */
-/* Hide outer shield for centered images */
-figure[typeof~='mw:Image'].mw-halign-center + .ve-ce-focusableNode-shield {
- display: none;
-}
-
-/* Override border on shields for images */
-.ve-ce-mwBlockImageNode .ve-ce-focusableNode-shield {
- border: none;
-}
-
/* Override paragraph margins inside of captions */
.ve-ce-mwBlockImageNode figcaption p {
margin: 0 !important;
diff --git a/modules/ve-mw/ce/styles/nodes/ve.ce.MWInlineImageNode.css
b/modules/ve-mw/ce/styles/nodes/ve.ce.MWInlineImageNode.css
index 69b2d3f..b8d0c33 100644
--- a/modules/ve-mw/ce/styles/nodes/ve.ce.MWInlineImageNode.css
+++ b/modules/ve-mw/ce/styles/nodes/ve.ce.MWInlineImageNode.css
@@ -8,8 +8,3 @@
.ve-ce-mwInlineImageNode {
display: inline-block;
}
-
-/* Override border on shields for images */
-.ve-ce-mwInlineImageNode .ve-ce-protectedNode-shield {
- border: none;
-}
\ No newline at end of file
diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
index 364a584..e00d304 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget-monobook.css
@@ -9,11 +9,6 @@
margin: -0.6em -0.8em 1em -0.8em;
}
-.ve-ui-context-frame-overlay {
- font-size: 1.25em;
-}
-
-.ve-ui-context,
.oo-ui-toolbar {
font-size: 1.25em;
line-height: 1.5em;
diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.Icons.css
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.Icons.css
deleted file mode 100644
index 72981a5..0000000
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.Icons.css
+++ /dev/null
@@ -1,16 +0,0 @@
-/*!
- * VisualEditor MediaWiki Initialization ViewPageTarget icon styles.
- *
- * @copyright 2011-2014 VisualEditor Team and others; see AUTHORS.txt
- * @license The MIT License (MIT); see LICENSE.txt
- */
-
-.ve-init-mw-viewPageTarget-saveDialog-prevButton {
- /* @embed */
- background-image: url(../../../ve/ui/styles/images/icons/move-rtl.svg);
-}
-
-.ve-init-mw-viewPageTarget-saveDialog-closeButton {
- /* @embed */
- background-image: url(../../../ve/ui/styles/images/icons/collapse.svg);
-}
diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
index 3ecdd33..60aa824 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
@@ -54,37 +54,11 @@
}
/* Needs to override .oo-ui.widget.oo-ui-widget-disabled */
-.ve-ui-toolbar-actions
.ve-init-mw-viewPageTarget-waiting.oo-ui-widget.oo-ui-widget-disabled {
+.ve-init-mw-viewPageTarget-waiting.oo-ui-widget.oo-ui-widget-disabled {
cursor: progress;
}
/* Tools */
-
-.ve-init-mw-viewPageTarget-tool {
- position: relative;
- display: inline-block;
- vertical-align: top;
- line-height: 2.8em;
- margin-right: 1em;
- padding-left: 30px;
- cursor: pointer;
- background-repeat: no-repeat;
- background-position: left center;
-}
-
-.ve-init-mw-viewPageTarget-tool-label {
- color: #555555;
-}
-
-.ve-init-mw-viewPageTarget-tool-beta-label {
- font-size: 120%;
- font-variant: small-caps;
-}
-
-.ve-init-mw-viewPageTarget-tool:hover .ve-init-mw-viewPageTarget-tool-label,
-.ve-init-mw-viewPageTarget-subtool-label:hover {
- text-decoration: underline;
-}
.ve-ui-mwNoticesPopupTool-items,
.ve-ui-mwHelpPopupTool-items {
@@ -112,10 +86,10 @@
margin-top: 0;
}
-.ve-init-mw-ViewPageTarget-version-label,
-.ve-init-mw-ViewPageTarget-version-link,
-.ve-init-mw-ViewPageTarget-version-date {
- font-size: 0.8em;
+.ve-ui-mwHelpPopupTool-version-label,
+.ve-ui-mwHelpPopupTool-version-link,
+.ve-ui-mwHelpPopupTool-version-date {
+ font-size: 0.9em;
color: #555;
}
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js
b/modules/ve-mw/init/ve.init.mw.Target.js
index 27fc539..0a9b158 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -254,7 +254,6 @@
* @property {string[]} iconModuleStyles Modules that should be loaded to
provide the icons
*/
ve.init.mw.Target.static.iconModuleStyles = [
- 'ext.visualEditor.viewPageTarget.icons',
'ext.visualEditor.icons'
];
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
index 709dce0..72147ef 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWLanguagesPage.js
@@ -60,7 +60,7 @@
var i, $languagesTable = this.$( '<table>' ), languageslength =
languages.length;
$languagesTable
- .addClass( 've-ui-MWLanguagesPage-languages-table' )
+ .addClass( 've-ui-mwLanguagesPage-languages-table' )
.append( this.$( '<tr>' )
.append(
this.$( '<th>' )
diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMetaDialog.css
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMetaDialog.css
index 1df03be..c3a01d7 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMetaDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWMetaDialog.css
@@ -5,7 +5,9 @@
* @license The MIT License (MIT); see LICENSE.txt
*/
-.ve-ui-mwMetaDialog-languages-table {
+/* Language page */
+
+.ve-ui-mwLanguagesPage-languages-table {
margin: 2em 0 0 0;
padding: 0;
width: 100%;
@@ -13,25 +15,25 @@
border-collapse: collapse;
}
-.ve-ui-mwMetaDialog-languages-table th {
+.ve-ui-mwLanguagesPage-languages-table th {
border-bottom: solid 1px #ddd;
text-align: left;
}
-.ve-ui-mwMetaDialog-languages-table th,
-.ve-ui-mwMetaDialog-languages-table td {
+.ve-ui-mwLanguagesPage-languages-table th,
+.ve-ui-mwLanguagesPage-languages-table td {
padding: 0.75em 1em;
border-bottom: solid 1px white;
}
-.ve-ui-mwMetaDialog-languages-table tr td:first-child {
+.ve-ui-mwLanguagesPage-languages-table tr td:first-child {
width: 30%;
}
-.ve-ui-mwMetaDialog-languages-table tr:nth-child(odd) td {
+.ve-ui-mwLanguagesPage-languages-table tr:nth-child(odd) td {
background: #F0F0F0;
}
-.ve-ui-mwMetaDialog-languages-table tr:nth-child(even) td {
+.ve-ui-mwLanguagesPage-languages-table tr:nth-child(even) td {
background: #F8F8F8;
}
diff --git a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
index 3ed48db..526f7cf 100644
--- a/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
+++ b/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.css
@@ -72,9 +72,7 @@
color: #aaa;
}
-.ve-ui-mwSaveDialog-license,
-.ve-ui-mwSaveDialog-dirtymsg,
-.ve-ui-mwSaveDialog-report-notice {
+.ve-ui-mwSaveDialog-license {
font-size: 0.85em;
line-height: 1.25em;
padding: 0;
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryPopupWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryPopupWidget.css
index 5089833..627a5f9 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryPopupWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWCategoryPopupWidget.css
@@ -31,10 +31,6 @@
margin: -0.4em 0 1em 0.125em;
}
-.ve-ui-mwCategoryPopupWidget .ve-ui-removeButtonLabel:hover {
- opacity: 1;
-}
-
.ve-ui-mwCategoryPopupWidget-removeButton {
position: absolute;
margin-right: 2px;
diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaResultWidget.css
b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaResultWidget.css
index fcdcbf1..c30f7fe 100644
--- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaResultWidget.css
+++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWMediaResultWidget.css
@@ -45,15 +45,7 @@
box-shadow: inset 0 0 0 1px #ccc;
}
-.ve-ui-optionWidget-highlighted .ve-ui-mwMediaResultWidget-overlay,
-.ve-ui-optionWidget-selected .ve-ui-mwMediaResultWidget-overlay {
- box-shadow: inset 0 0 0 1px #a7dcff;
-}
-
-.ve-ui-mwMediaResultWidget.oo-ui-optionWidget-highlighted {
- box-shadow: 0 0 0.3em #a7dcff, 0 0 0 white;
-}
-
+.ve-ui-mwMediaResultWidget.oo-ui-optionWidget-highlighted,
.ve-ui-mwMediaResultWidget.oo-ui-optionWidget-selected {
box-shadow: 0 0 0.3em #a7dcff, 0 0 0 white;
}
--
To view, visit https://gerrit.wikimedia.org/r/149924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76442a632c18d2133cdf78c4555da149c0a7888c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
