Trevor Parscal has uploaded a new change for review. https://gerrit.wikimedia.org/r/150051
Change subject: Update VE core submodule to 68c07ec0e39f210bb53a0dc777429d72f454d600 ...................................................................... Update VE core submodule to 68c07ec0e39f210bb53a0dc777429d72f454d600 New changes: 84ac603 Use shorthand for collapsed ranges 542dc47 SVG fixes 8686f85 Move non-icon/indicator styles out of ve.ui.Icons.css 91a5630 Localisation updates from https://translatewiki.net. 978e223 Function name fix 7558ed0 Add 'snowman' and '☃' in comment for greppability af0e8b1 Localisation updates from https://translatewiki.net. 68c07ec Update OOjs UI to v0.1.0-pre (b0e8f2d611) Update changes: * Use this.$content instead of this.frame.$content Change-Id: Ia83449a60078dd24ea4f976221c0859e5a121279 --- M lib/ve M modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js M modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js 5 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/51/150051/1 diff --git a/lib/ve b/lib/ve index 433007d..68c07ec 160000 --- a/lib/ve +++ b/lib/ve -Subproject commit 433007d0759bbe5891b62257c08bc18fb9b5992f +Subproject commit 68c07ec0e39f210bb53a0dc777429d72f454d600 diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js index b1d5bec..ae88748 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWCitationDialog.js @@ -81,7 +81,7 @@ ve.ui.MWCitationDialog.super.prototype.initialize.call( this, data ); // HACK: Use the same styling as single-mode transclusion dialog - this should be generalized - this.frame.$content.addClass( 've-ui-mwTransclusionDialog-single' ); + this.$content.addClass( 've-ui-mwTransclusionDialog-single' ); }; /** diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js index 98ae27a..c8f329c 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js @@ -644,7 +644,7 @@ // Hide/show buttons this.actions.setMode( this.selectedNode ? 'edit' : 'insert' ); // HACK: OO.ui.Dialog needs an API for this - this.frame.$content.removeClass( 'oo-ui-dialog-content-footless' ); + this.$content.removeClass( 'oo-ui-dialog-content-footless' ); // Hide/show the panels this.bookletLayout.$element.show(); this.mediaSearchPanel.$element.hide(); @@ -682,7 +682,7 @@ this.actions.setMode( this.imageModel ? 'change' : 'select' ); // HACK: OO.ui.Dialog needs an API for this - this.frame.$content.toggleClass( 'oo-ui-dialog-content-footless', !this.imageModel ); + this.$content.toggleClass( 'oo-ui-dialog-content-footless', !this.imageModel ); // Hide/show the panels this.bookletLayout.$element.hide(); diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js index 49ce531..b0d4004 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js @@ -326,7 +326,7 @@ ); // Initialization - this.frame.$content.addClass( 've-ui-mwTemplateDialog' ); + this.$content.addClass( 've-ui-mwTemplateDialog' ); this.$body.append( this.panels.$element ); this.panels.addItems( [ this.bookletLayout ] ); }; diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js index da63f4a..45c3e28 100644 --- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js +++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js @@ -222,9 +222,9 @@ } this.mode = mode; single = mode === 'single'; - if ( this.frame.$content ) { + if ( this.$content ) { for ( name in modeCssClasses ) { - this.frame.$content.toggleClass( modeCssClasses[name], name === mode ); + this.$content.toggleClass( modeCssClasses[name], name === mode ); } } this.setSize( single ? 'medium' : 'large' ); -- To view, visit https://gerrit.wikimedia.org/r/150051 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia83449a60078dd24ea4f976221c0859e5a121279 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
