jenkins-bot has submitted this change and it was merged.
Change subject: Clicking on 'Edit title' leads to edit title page
......................................................................
Clicking on 'Edit title' leads to edit title page
overrides should have a default value if not defined
Change-Id: Ic2b62e581e5971cde0fe3abfe913a70383d7c029
---
M modules/new/flow-api.js
M modules/new/mw-ui.enhance.js
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/new/flow-api.js b/modules/new/flow-api.js
index e93919e..eca8d4c 100644
--- a/modules/new/flow-api.js
+++ b/modules/new/flow-api.js
@@ -185,6 +185,7 @@
$node, $form, formData;
queryMap = queryMap || {};
+ overrides = overrides || [];
// If URL is an Element...
if ( typeof url !== 'string' ) {
diff --git a/modules/new/mw-ui.enhance.js b/modules/new/mw-ui.enhance.js
index 056aee9..bca0db9 100644
--- a/modules/new/mw-ui.enhance.js
+++ b/modules/new/mw-ui.enhance.js
@@ -413,8 +413,8 @@
.on( 'mouseleave.mw-ui-enhance blur.mw-ui-enhance
click.mw-ui-enhance', '.flow-ui-tooltip-target', onMwUiTooltipBlur );
} );
- /*
- Ask a user to confirm navigating away from a page when they have
entered unsubmitted changes to a form.
+ /**
+ * Ask a user to confirm navigating away from a page when they have
entered unsubmitted changes to a form.
*/
var _oldOnBeforeUnload = window.onbeforeunload;
window.onbeforeunload = function () {
--
To view, visit https://gerrit.wikimedia.org/r/149365
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2b62e581e5971cde0fe3abfe913a70383d7c029
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
