jenkins-bot has submitted this change and it was merged.

Change subject: Resources.php: Remove/deprecate 'skinStyles' references to 
'minerva' skin
......................................................................


Resources.php: Remove/deprecate 'skinStyles' references to 'minerva' skin

It doesn't even exist in core: it is part of the MobileFrontend
extension. The skin style overrides should be reapplied there using
$wgResourceModuleSkinStyles: done in I30c8ce13.

OOjs UI has some weird build process that currently requires this, though.
According to James, that will be fixed "in a couple of months".

Change-Id: If82556a41c0510a70796a09b3555d2c91a7abb52
---
M resources/Resources.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/Resources.php b/resources/Resources.php
index 46a342c..78c0fe7 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -113,7 +113,6 @@
                // skin over-rides common content styling.
                'skinStyles' => array(
                        'default' => 
'resources/src/mediawiki.skinning/content.parsoid.less',
-                       'minerva' => array(),
                ),
                'targets' => array( 'desktop', 'mobile' ),
        ),
@@ -1471,6 +1470,7 @@
                ),
                'skinStyles' => array(
                        'default' => 'resources/lib/oojs-ui/oojs-ui-apex.css',
+                       // FIXME As of July 2014, this is to be gone "in a 
couple of months".
                        'minerva' => 'resources/lib/oojs-ui/oojs-ui-agora.css',
                ),
                'messages' => array(

-- 
To view, visit https://gerrit.wikimedia.org/r/148305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If82556a41c0510a70796a09b3555d2c91a7abb52
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Isarra <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to