jenkins-bot has submitted this change and it was merged.
Change subject: DM 1.0 compat: do not use Entity::toArray
......................................................................
DM 1.0 compat: do not use Entity::toArray
Change-Id: Ib02ed4e0e03b0c050354faf35b65d2ed9307d6a5
---
M lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php
1 file changed, 0 insertions(+), 24 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git
a/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php
b/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php
index 7ef0b38..4bd0f39 100644
--- a/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php
+++ b/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php
@@ -22,30 +22,6 @@
*/
class LegacyInternalEntitySerializerTest extends \PHPUnit_Framework_TestCase {
- public function entityProvider() {
- $empty = Item::newEmpty();
-
- $withLabels = Item::newEmpty();
- $withLabels->setLabel( 'en', 'Hello' );
- $withLabels->setLabel( 'es', 'Holla' );
-
- return array(
- array( $empty ),
- array( $withLabels ),
- );
- }
-
- /**
- * @dataProvider entityProvider
- * @param Entity $entity
- */
- public function testSerialize( Entity $entity ) {
- $serializer = new LegacyInternalEntitySerializer();
- $data = $serializer->serialize( $entity );
-
- $this->assertEquals( $entity->toArray(), $data );
- }
-
public function legacyFormatBlobProvider() {
$entity = Item::newEmpty();
$entity->setId( new ItemId( 'Q12' ) );
--
To view, visit https://gerrit.wikimedia.org/r/149237
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib02ed4e0e03b0c050354faf35b65d2ed9307d6a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
