Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150419
Change subject: Don't show PostEdit message if we made a null edit.
......................................................................
Don't show PostEdit message if we made a null edit.
Bug: 51243
Change-Id: I63b2405c854e2953976dc8ca7a5a136308a7dcf0
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 11 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/19/150419/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 0fe123e..dccab6b 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -429,14 +429,15 @@
* @param {string} displayTitle What HTML to show as the page title
*/
ve.init.mw.ViewPageTarget.prototype.onSave = function ( html, categoriesHtml,
newid, isRedirect, displayTitle ) {
- var newUrlParams, watchChecked;
+ var newUrlParams = {}, watchChecked;
this.saveDeferred.resolve();
if ( !this.pageExists || this.restoring ) {
// This is a page creation or restoration, refresh the page
this.tearDownBeforeUnloadHandler();
- newUrlParams = {
- 'venotify': this.restoring ? 'restored' : 'created'
- };
+ if ( newid !== undefined ) {
+ newUrlParams.venotify = this.restoring ? 'restored' :
'created';
+ }
+
if ( isRedirect ) {
newUrlParams.redirect = 'no';
}
@@ -475,10 +476,12 @@
this.setupSectionEditLinks();
this.tearDownBeforeUnloadHandler();
this.deactivate( true );
- mw.hook( 'postEdit' ).fire( {
- 'message':
- ve.msg( 'postedit-confirmation-saved', mw.user )
- } );
+ if ( newid !== undefined ) {
+ mw.hook( 'postEdit' ).fire( {
+ 'message':
+ ve.msg( 'postedit-confirmation-saved',
mw.user )
+ } );
+ }
}
};
--
To view, visit https://gerrit.wikimedia.org/r/150419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63b2405c854e2953976dc8ca7a5a136308a7dcf0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
