Mwalker has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/150865

Change subject: Actually keep the temp image files...
......................................................................

Actually keep the temp image files...

Because otherwise we cannot render them :)

Change-Id: I48260871d4fd741302935ba260a35f7675b8072f
---
M lib/image.js
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection/OfflineContentGenerator/bundler
 refs/changes/65/150865/1

diff --git a/lib/image.js b/lib/image.js
index 37d1382..fd7d3a1 100644
--- a/lib/image.js
+++ b/lib/image.js
@@ -99,12 +99,12 @@
                        if (!Image.COMPAT_FILENAMES) {
                                return tmpFile({
                                        dir: imagedir,
-                                       postfix: path.extname(proposedName)
+                                       postfix: path.extname(proposedName),
+                                       keep: true
                                });
                        }
                        // If Image.COMPAT_FILENAMES is set, create a name 
based on the
                        // original filename (easier debug!)
-                       var name = cleanFilename(proposedName);
                        return P.call(fs.open, fs, path.join(imagedir, name), 
'w+').then(function(fd) {
                                return [path.join(imagedir, name), fd];
                        }).catch(function(err) {
@@ -117,7 +117,8 @@
                                return tmpFile({
                                        dir: imagedir,
                                        prefix: trimname,
-                                       postfix: ext // limit len
+                                       postfix: ext, // limit len
+                                       keep: true
                                });
                        });
                }).spread(function(name, fd) {

-- 
To view, visit https://gerrit.wikimedia.org/r/150865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I48260871d4fd741302935ba260a35f7675b8072f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection/OfflineContentGenerator/bundler
Gerrit-Branch: master
Gerrit-Owner: Mwalker <mwal...@khaosdev.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to