JGonera has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/151807

Change subject: Disable basic reference on mobile
......................................................................

Disable basic reference on mobile

Use `tool` property of tools to determine if a reference node should be
filtered out. We can't use the `tool` property instead of `model` in other
cases for whitelisting because of GeneratedMWCitationDialogTool
which is not exposed publicly.

Bug: 68897
Change-Id: I5a0d3d7623cdf58b2cc7a0dc41e22eed19a84914
---
M modules/ve/ui/ve.ui.MobileContext.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/07/151807/1

diff --git a/modules/ve/ui/ve.ui.MobileContext.js 
b/modules/ve/ui/ve.ui.MobileContext.js
index 51cf072..595c5ca 100644
--- a/modules/ve/ui/ve.ui.MobileContext.js
+++ b/modules/ve/ui/ve.ui.MobileContext.js
@@ -87,7 +87,7 @@
                return (
                        tool.model instanceof ve.dm.MWInternalLinkAnnotation ||
                        tool.model instanceof ve.dm.MWExternalLinkAnnotation ||
-                       tool.model instanceof ve.dm.MWReferenceNode
+                       ( tool.model instanceof ve.dm.MWReferenceNode && 
tool.tool !== ve.ui.MWReferenceDialogTool )
                );
        } );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/151807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a0d3d7623cdf58b2cc7a0dc41e22eed19a84914
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to