Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/151817

Change subject: get fancy with a log message /me wags eyebrows
......................................................................

get fancy with a log message /me wags eyebrows

Change-Id: I8fde1086a9ad864c52f30d4951245e8c33ba3479
---
M sites/all/modules/offline2civicrm/ChecksFile.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/17/151817/1

diff --git a/sites/all/modules/offline2civicrm/ChecksFile.php 
b/sites/all/modules/offline2civicrm/ChecksFile.php
index 29eefd2..d8cd6cf 100644
--- a/sites/all/modules/offline2civicrm/ChecksFile.php
+++ b/sites/all/modules/offline2civicrm/ChecksFile.php
@@ -17,7 +17,7 @@
      * Read checks from a file and save to the database.
      */
     function import() {
-        ChecksImportLog::record( "Beginning import of checks file 
{$this->file_uri}..." );
+        ChecksImportLog::record( "Beginning import of checks file 
'{$this->file_uri}', of type " . get_class($this
         //TODO: $db->begin();
 
         ini_set( 'auto_detect_line_endings', true );
@@ -61,7 +61,7 @@
             try {
                 $msg = $this->parseRow( $data );
 
-                // check to see if we have already processed this check
+                // FIXME: This is already handled by shared message import code
                 if ( $existing = 
wmf_civicrm_get_contributions_from_gateway_id( $msg['gateway'], 
$msg['gateway_txn_id'] ) ){
                     // if so, move on
                     watchdog( 'offline2civicrm', 'Contribution matches 
existing contribution (id: @id), skipping it.', array( '@id' => 
$existing[0]['id'] ), WATCHDOG_INFO );

-- 
To view, visit https://gerrit.wikimedia.org/r/151817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fde1086a9ad864c52f30d4951245e8c33ba3479
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to