Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/151972

Change subject: $checkmatrixOptions has an extra '-' in the key
......................................................................

$checkmatrixOptions has an extra '-' in the key

examples:

1. prefix: echo-subscriptions-
   column: email
   row: flow-discussion
this is saved in user_properties as echo-subscriptions-email-flow-discussion, 
but
it's generated as echo-subscriptions--email-flow-discussion in 
User::getOptionKinds()

2. prefix: echo-subscriptions
   column: email
   row: flow-discussion
this is saved in user_properties as echo-subscriptionsemali-flow-discussion but
it's generated as echo-subscriptions-email-flow-discussion in 
User::getOptionKinds()

Bug: 69146
Change-Id: I69ed9c875443ba44d1a5e12e51165ebf8d6d6a06
---
M includes/User.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/151972/1

diff --git a/includes/User.php b/includes/User.php
index fe41187..7e846ad 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -2733,7 +2733,7 @@
 
                                foreach ( $columns as $column ) {
                                        foreach ( $rows as $row ) {
-                                               
$checkmatrixOptions["$prefix-$column-$row"] = true;
+                                               
$checkmatrixOptions["$prefix$column-$row"] = true;
                                        }
                                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/151972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69ed9c875443ba44d1a5e12e51165ebf8d6d6a06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to