Lewis Cawte has uploaded a new change for review. https://gerrit.wikimedia.org/r/152231
Change subject: Send email from $wgPasswordSender instead of user's email to stop emails going to spam if an SPF record is set. See: https://www.mediawiki.org/wiki/Thread:Extension_talk:InviteSignup/Sending_mails_from_users%27_addresses_is_not_a_great_idea ...................................................................... Send email from $wgPasswordSender instead of user's email to stop emails going to spam if an SPF record is set. See: https://www.mediawiki.org/wiki/Thread:Extension_talk:InviteSignup/Sending_mails_from_users%27_addresses_is_not_a_great_idea Change-Id: I1d39996697223966a7abbc40713df2aeb9ed3763 --- M SpecialInviteSignup.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/InviteSignup refs/changes/31/152231/1 diff --git a/SpecialInviteSignup.php b/SpecialInviteSignup.php index 8ff0e9e..b57d42c 100644 --- a/SpecialInviteSignup.php +++ b/SpecialInviteSignup.php @@ -172,6 +172,7 @@ } public static function sendInviteEmail( User $inviter, $email, $hash ) { + global $wgPasswordSender; $url = Title::newFromText( 'Special:Userlogin/signup' )->getCanonicalUrl( array( 'invite' => $hash, 'returnto' => 'Special:Dashboard' ) ); $subj = wfMessage( 'is-emailsubj' )->inContentLanguage(); @@ -179,11 +180,10 @@ ->params( $inviter->getName(), $url ) ->inContentLanguage(); - $emailFrom = new MailAddress( $inviter ); $emailTo = new MailAddress( $email ); $params = array( 'to' => $emailTo, - 'from' => $emailFrom, + 'from' => $wgPasswordSender, 'replyto' => $emailFrom, 'body' => $body->text(), 'subj' => $subj->text(), -- To view, visit https://gerrit.wikimedia.org/r/152231 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d39996697223966a7abbc40713df2aeb9ed3763 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/InviteSignup Gerrit-Branch: master Gerrit-Owner: Lewis Cawte <le...@lewiscawte.me> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
