Bsitu has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153006
Change subject: Missing sectionId in flow_anon_warning.handlebars
......................................................................
Missing sectionId in flow_anon_warning.handlebars
Change-Id: I5d7289408959d85b7e5735dd8aafb8557f308cca
Notice: Undefined index: sectionId in TemplateHelper.php on line 616
---
M handlebars/compiled/flow_block_topic_edit_post.handlebars.php
M handlebars/compiled/flow_block_topic_reply.handlebars.php
M handlebars/compiled/flow_block_topiclist.handlebars.php
M handlebars/compiled/flow_block_topiclist_newtopic.handlebars.php
M handlebars/flow_anon_warning.handlebars
5 files changed, 44 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/06/153006/1
diff --git a/handlebars/compiled/flow_block_topic_edit_post.handlebars.php
b/handlebars/compiled/flow_block_topic_edit_post.handlebars.php
index 14a6cd4..ca4e792 100644
--- a/handlebars/compiled/flow_block_topic_edit_post.handlebars.php
+++ b/handlebars/compiled/flow_block_topic_edit_post.handlebars.php
@@ -18,6 +18,7 @@
'hbhelpers' => Array( 'eachPost' =>
'Flow\TemplateHelper::eachPost',
'ifAnonymous' => 'Flow\TemplateHelper::ifAnonymous',
'tooltip' => 'Flow\TemplateHelper::tooltip',
+ 'progressiveEnhancement' =>
'Flow\TemplateHelper::progressiveEnhancement',
),
'scopes' => Array($in),
'sp_vars' => Array(),
@@ -44,8 +45,21 @@
<input type="hidden" name="wpEditToken"
value="'.htmlentities(((is_array($cx['scopes'][0]) &&
isset($cx['scopes'][0]['editToken'])) ? $cx['scopes'][0]['editToken'] : null),
ENT_QUOTES, 'UTF-8').'" />
<input type="hidden" name="topic_prev_revision"
value="'.htmlentities(((is_array($in) && isset($in['revisionId'])) ?
$in['revisionId'] : null), ENT_QUOTES, 'UTF-8').'" />
'.LCRun3::hbch($cx, 'ifAnonymous', Array(Array(),Array()), $in,
function($cx, $in) {return '
- '.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'down','contextClass'=>'progressive','extraClass'=>'flow-anon-warning
flow-form-collapsible','isBlock'=>true)), $in, function($cx, $in) {return '
- '.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
+ <div class="flow-anon-warning">
+ <div class="flow-anon-warning-mobile">
+ '.'
+ '.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'down','contextClass'=>'progressive','extraClass'=>'flow-form-collapsible','isBlock'=>true)),
$in, function($cx, $in) {return '
+ '.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
+ </div>
+
+ '.'
+ '.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion','sectionId'=>'flow-anon-warning')),
$in, function($cx, $in) {return '
+ <div class="flow-anon-warning-desktop">
+ '.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'left','contextClass'=>'progressive','extraClass'=>'flow-form-collapsible','isBlock'=>true)),
$in, function($cx, $in) {return '
+ '.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
+ </div>
+ ';}).'
+</div>
';}).'
<textarea name="topic_content" class="mw-ui-input flow-form-collapsible"
@@ -60,8 +74,11 @@
name="preview"
data-role="action"
class="mw-ui-button mw-ui-progressive mw-ui-quiet
mw-ui-flush-right">'.LCRun3::ch($cx, 'l10n',
Array(Array('flow-preview'),Array()), 'encq').'</button>
-<button data-flow-interactive-handler="cancelForm" data-role="cancel"
+
+'.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion','sectionId'=>'flow-cancel-button')),
$in, function($cx, $in) {return '
+ <button data-flow-interactive-handler="cancelForm" data-role="cancel"
class="mw-ui-button mw-ui-destructive mw-ui-quiet
mw-ui-flush-right">'.LCRun3::ch($cx, 'l10n',
Array(Array('flow-cancel'),Array()), 'encq').'</button>
+';}).'
<small class="flow-terms-of-use plainlinks">'.LCRun3::ch($cx,
'l10nParse', Array(Array('flow-terms-of-use-edit'),Array()), 'encq').'</small>
</div>
diff --git a/handlebars/compiled/flow_block_topic_reply.handlebars.php
b/handlebars/compiled/flow_block_topic_reply.handlebars.php
index 20c27aa..10cb7f6 100644
--- a/handlebars/compiled/flow_block_topic_reply.handlebars.php
+++ b/handlebars/compiled/flow_block_topic_reply.handlebars.php
@@ -17,6 +17,7 @@
'blockhelpers' => Array(),
'hbhelpers' => Array( 'eachPost' =>
'Flow\TemplateHelper::eachPost',
'ifEquals' => 'Flow\TemplateHelper::ifEquals',
+ 'progressiveEnhancement' =>
'Flow\TemplateHelper::progressiveEnhancement',
),
'scopes' => Array($in),
'sp_vars' => Array(),
@@ -58,8 +59,11 @@
name="preview"
data-role="action"
class="mw-ui-button mw-ui-progressive mw-ui-quiet
mw-ui-flush-right">'.LCRun3::ch($cx, 'l10n',
Array(Array('flow-preview'),Array()), 'encq').'</button>
-<button data-flow-interactive-handler="cancelForm" data-role="cancel"
+
+'.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion','sectionId'=>'flow-cancel-button')),
$in, function($cx, $in) {return '
+ <button data-flow-interactive-handler="cancelForm" data-role="cancel"
class="mw-ui-button mw-ui-destructive mw-ui-quiet
mw-ui-flush-right">'.LCRun3::ch($cx, 'l10n',
Array(Array('flow-cancel'),Array()), 'encq').'</button>
+';}).'
<small class="flow-terms-of-use
plainlinks">'.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-terms-of-use-reply'),Array()), 'encq').'</small>
</div>
diff --git a/handlebars/compiled/flow_block_topiclist.handlebars.php
b/handlebars/compiled/flow_block_topiclist.handlebars.php
index dcdaccb..2b49eed 100644
--- a/handlebars/compiled/flow_block_topiclist.handlebars.php
+++ b/handlebars/compiled/flow_block_topiclist.handlebars.php
@@ -110,7 +110,7 @@
</div>
'.'
- '.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion')), $in, function($cx, $in)
{return '
+ '.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion','sectionId'=>'flow-anon-warning')),
$in, function($cx, $in) {return '
<div class="flow-anon-warning-desktop">
'.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'left','contextClass'=>'progressive','extraClass'=>'flow-form-collapsible','isBlock'=>true)),
$in, function($cx, $in) {return '
'.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
@@ -428,7 +428,7 @@
</div>
'.'
- '.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion')), $in, function($cx, $in)
{return '
+ '.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion','sectionId'=>'flow-anon-warning')),
$in, function($cx, $in) {return '
<div class="flow-anon-warning-desktop">
'.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'left','contextClass'=>'progressive','extraClass'=>'flow-form-collapsible','isBlock'=>true)),
$in, function($cx, $in) {return '
'.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
@@ -493,4 +493,4 @@
</div>
';
}
-?>
+?>
\ No newline at end of file
diff --git a/handlebars/compiled/flow_block_topiclist_newtopic.handlebars.php
b/handlebars/compiled/flow_block_topiclist_newtopic.handlebars.php
index f205076..4e1daae 100644
--- a/handlebars/compiled/flow_block_topiclist_newtopic.handlebars.php
+++ b/handlebars/compiled/flow_block_topiclist_newtopic.handlebars.php
@@ -40,8 +40,21 @@
'.LCRun3::hbch($cx, 'ifAnonymous', Array(Array(),Array()), $in,
function($cx, $in) {return '
- '.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'down','contextClass'=>'progressive','extraClass'=>'flow-anon-warning
flow-form-collapsible','isBlock'=>true)), $in, function($cx, $in) {return '
- '.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
+ <div class="flow-anon-warning">
+ <div class="flow-anon-warning-mobile">
+ '.'
+ '.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'down','contextClass'=>'progressive','extraClass'=>'flow-form-collapsible','isBlock'=>true)),
$in, function($cx, $in) {return '
+ '.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
+ </div>
+
+ '.'
+ '.LCRun3::hbch($cx, 'progressiveEnhancement',
Array(Array(),Array('insertionType'=>'insertion','sectionId'=>'flow-anon-warning')),
$in, function($cx, $in) {return '
+ <div class="flow-anon-warning-desktop">
+ '.LCRun3::hbch($cx, 'tooltip',
Array(Array(),Array('positionClass'=>'left','contextClass'=>'progressive','extraClass'=>'flow-form-collapsible','isBlock'=>true)),
$in, function($cx, $in) {return '
+ '.LCRun3::ch($cx, 'l10nParse',
Array(Array('flow-anon-warning',LCRun3::ch($cx, 'linkWithReturnTo',
Array(Array('Special:UserLogin'),Array()), 'raw'),LCRun3::ch($cx,
'linkWithReturnTo', Array(Array('Special:UserLogin/signup'),Array()),
'raw')),Array()), 'encq').'';}).'
+ </div>
+ ';}).'
+</div>
';}).'
<input type="hidden" name="wpEditToken"
value="'.htmlentities(((is_array($cx['scopes'][0]) &&
isset($cx['scopes'][0]['editToken'])) ? $cx['scopes'][0]['editToken'] : null),
ENT_QUOTES, 'UTF-8').'" />
diff --git a/handlebars/flow_anon_warning.handlebars
b/handlebars/flow_anon_warning.handlebars
index f4e7125..f370bb9 100644
--- a/handlebars/flow_anon_warning.handlebars
+++ b/handlebars/flow_anon_warning.handlebars
@@ -12,7 +12,7 @@
</div>
{{!-- desktop warning --}}
- {{#progressiveEnhancement insertionType="insertion"}}
+ {{#progressiveEnhancement insertionType="insertion"
sectionId="flow-anon-warning"}}
<div class="flow-anon-warning-desktop">
{{#tooltip
positionClass="left"
--
To view, visit https://gerrit.wikimedia.org/r/153006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d7289408959d85b7e5735dd8aafb8557f308cca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
