Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153608
Change subject: Remove unused imports from Lib ...................................................................... Remove unused imports from Lib Change-Id: Ia2ae11c8e1fb6e47a1b5b1a3d30c6cb6fe339392 --- M lib/includes/Reporting/ReportingExceptionHandler.php M lib/includes/formatters/EntityIdHtmlLinkFormatter.php M lib/includes/formatters/EntityIdLabelFormatter.php M lib/includes/serializers/LegacyInternalEntitySerializer.php M lib/includes/serializers/SnakSerializer.php M lib/includes/store/CachingEntityRevisionLookup.php M lib/includes/store/EntityStore.php M lib/includes/store/UnresolvedRedirectException.php M lib/includes/store/sql/SqlEntityInfoBuilderFactory.php M lib/tests/phpunit/EntityRetrievingDataTypeLookupTest.php M lib/tests/phpunit/MockRepositoryTest.php M lib/tests/phpunit/MockSiteStore.php M lib/tests/phpunit/changes/ItemChangeTest.php M lib/tests/phpunit/changes/TestChanges.php M lib/tests/phpunit/entity/EntityFactoryTest.php M lib/tests/phpunit/formatters/EntityIdLabelFormatterTest.php M lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php M lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php M lib/tests/phpunit/serializers/DispatchingEntitySerializerTest.php M lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php M lib/tests/phpunit/store/CachingEntityRevisionLookupTest.php M lib/tests/phpunit/store/ItemUsageIndexTest.php M lib/tests/phpunit/store/SiteLinkTableTest.php 23 files changed, 18 insertions(+), 30 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/08/153608/1 diff --git a/lib/includes/Reporting/ReportingExceptionHandler.php b/lib/includes/Reporting/ReportingExceptionHandler.php index d2daebc..2157121 100644 --- a/lib/includes/Reporting/ReportingExceptionHandler.php +++ b/lib/includes/Reporting/ReportingExceptionHandler.php @@ -3,7 +3,6 @@ namespace Wikibase\Lib\Reporting; use Exception; -use Wikibase\Lib\Reporting\MessageReporter; /** * ReportingExceptionHandler reports exceptions to a MessageReporter. diff --git a/lib/includes/formatters/EntityIdHtmlLinkFormatter.php b/lib/includes/formatters/EntityIdHtmlLinkFormatter.php index 8e3090f..2273325 100644 --- a/lib/includes/formatters/EntityIdHtmlLinkFormatter.php +++ b/lib/includes/formatters/EntityIdHtmlLinkFormatter.php @@ -7,8 +7,8 @@ use Title; use ValueFormatters\FormatterOptions; use Wikibase\DataModel\Entity\EntityId; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\EntityTitleLookup; +use Wikibase\Lib\Store\EntityLookup; /** * Formats entity IDs by generating an HTML link to the corresponding page title. diff --git a/lib/includes/formatters/EntityIdLabelFormatter.php b/lib/includes/formatters/EntityIdLabelFormatter.php index 47df8d0..f108ebb 100644 --- a/lib/includes/formatters/EntityIdLabelFormatter.php +++ b/lib/includes/formatters/EntityIdLabelFormatter.php @@ -7,8 +7,8 @@ use ValueFormatters\FormatterOptions; use ValueFormatters\FormattingException; use Wikibase\DataModel\Entity\EntityId; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\LanguageFallbackChain; +use Wikibase\Lib\Store\EntityLookup; use Wikibase\Lib\Store\StorageException; use Wikibase\Lib\Store\UnresolvedRedirectException; diff --git a/lib/includes/serializers/LegacyInternalEntitySerializer.php b/lib/includes/serializers/LegacyInternalEntitySerializer.php index 08d87f8..062bbf3 100644 --- a/lib/includes/serializers/LegacyInternalEntitySerializer.php +++ b/lib/includes/serializers/LegacyInternalEntitySerializer.php @@ -3,8 +3,8 @@ namespace Wikibase\Lib\Serializers; use InvalidArgumentException; -use Wikibase\DataModel\Entity\Entity; use Serializers\Serializer as NewStyleSerializer; +use Wikibase\DataModel\Entity\Entity; /** * Serializer for generating the legacy serialization of an Entity. diff --git a/lib/includes/serializers/SnakSerializer.php b/lib/includes/serializers/SnakSerializer.php index cbf315c..5993a1a 100644 --- a/lib/includes/serializers/SnakSerializer.php +++ b/lib/includes/serializers/SnakSerializer.php @@ -4,13 +4,11 @@ use DataValues\DataValueFactory; use InvalidArgumentException; -use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\PropertyId; use Wikibase\Lib\PropertyDataTypeLookup; use Wikibase\Lib\PropertyNotFoundException; use Wikibase\PropertyValueSnak; use Wikibase\Snak; -use Wikibase\SnakObject; /** * Serializer for Snak objects. diff --git a/lib/includes/store/CachingEntityRevisionLookup.php b/lib/includes/store/CachingEntityRevisionLookup.php index 84542ee..c6073cd 100644 --- a/lib/includes/store/CachingEntityRevisionLookup.php +++ b/lib/includes/store/CachingEntityRevisionLookup.php @@ -3,7 +3,6 @@ namespace Wikibase\Lib\Store; use BagOStuff; -use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\EntityId; use Wikibase\EntityRevision; diff --git a/lib/includes/store/EntityStore.php b/lib/includes/store/EntityStore.php index 28f9da4..2dd5a11 100644 --- a/lib/includes/store/EntityStore.php +++ b/lib/includes/store/EntityStore.php @@ -7,7 +7,6 @@ use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\EntityId; use Wikibase\EntityRevision; -use Wikibase\Lib\Store\StorageException; /** * Storage interface for Entities. diff --git a/lib/includes/store/UnresolvedRedirectException.php b/lib/includes/store/UnresolvedRedirectException.php index a8a5081..501fdc2 100644 --- a/lib/includes/store/UnresolvedRedirectException.php +++ b/lib/includes/store/UnresolvedRedirectException.php @@ -3,7 +3,6 @@ use Exception; use Wikibase\DataModel\Entity\EntityId; -use Wikibase\Lib\Store\StorageException; /** * Exception indicating that an attempt was made to access a redirected EntityId diff --git a/lib/includes/store/sql/SqlEntityInfoBuilderFactory.php b/lib/includes/store/sql/SqlEntityInfoBuilderFactory.php index ba487a2..c04fa7a 100644 --- a/lib/includes/store/sql/SqlEntityInfoBuilderFactory.php +++ b/lib/includes/store/sql/SqlEntityInfoBuilderFactory.php @@ -4,7 +4,6 @@ use InvalidArgumentException; use Wikibase\DataModel\Entity\EntityId; -use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\Lib\Store\EntityInfoBuilder; use Wikibase\Lib\Store\EntityInfoBuilderFactory; use Wikibase\Lib\Store\EntityRevisionLookup; diff --git a/lib/tests/phpunit/EntityRetrievingDataTypeLookupTest.php b/lib/tests/phpunit/EntityRetrievingDataTypeLookupTest.php index 43b1e4d..e298e3d 100644 --- a/lib/tests/phpunit/EntityRetrievingDataTypeLookupTest.php +++ b/lib/tests/phpunit/EntityRetrievingDataTypeLookupTest.php @@ -2,9 +2,9 @@ namespace Wikibase\Lib\Test; +use Wikibase\DataModel\Entity\Property; use Wikibase\DataModel\Entity\PropertyId; use Wikibase\Lib\EntityRetrievingDataTypeLookup; -use Wikibase\DataModel\Entity\Property; use Wikibase\Test\MockRepository; /** diff --git a/lib/tests/phpunit/MockRepositoryTest.php b/lib/tests/phpunit/MockRepositoryTest.php index b3828c3..f080c4c 100644 --- a/lib/tests/phpunit/MockRepositoryTest.php +++ b/lib/tests/phpunit/MockRepositoryTest.php @@ -4,12 +4,12 @@ use User; use Wikibase\DataModel\Entity\BasicEntityIdParser; -use Wikibase\DataModel\Entity\ItemId; -use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\DataModel\SiteLink; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\Item; +use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\Entity\Property; +use Wikibase\DataModel\Entity\PropertyId; +use Wikibase\DataModel\SiteLink; use Wikibase\Lib\Store\EntityRedirect; /** diff --git a/lib/tests/phpunit/MockSiteStore.php b/lib/tests/phpunit/MockSiteStore.php index 8b907ad..9f3dd7f 100644 --- a/lib/tests/phpunit/MockSiteStore.php +++ b/lib/tests/phpunit/MockSiteStore.php @@ -5,7 +5,6 @@ use Site; use SiteList; use SiteStore; -use TestSites; /** * @license GPL 2+ diff --git a/lib/tests/phpunit/changes/ItemChangeTest.php b/lib/tests/phpunit/changes/ItemChangeTest.php index 1cd3575..05a6c72 100644 --- a/lib/tests/phpunit/changes/ItemChangeTest.php +++ b/lib/tests/phpunit/changes/ItemChangeTest.php @@ -6,10 +6,10 @@ use Diff\DiffOp\DiffOpChange; use Exception; use Wikibase\DataModel\Entity\Entity; -use Wikibase\EntityChange; use Wikibase\DataModel\Entity\Item; -use Wikibase\ItemChange; use Wikibase\DataModel\Entity\ItemDiff; +use Wikibase\EntityChange; +use Wikibase\ItemChange; /** * @covers Wikibase\ItemChange diff --git a/lib/tests/phpunit/changes/TestChanges.php b/lib/tests/phpunit/changes/TestChanges.php index 6cea048..f9a9346 100644 --- a/lib/tests/phpunit/changes/TestChanges.php +++ b/lib/tests/phpunit/changes/TestChanges.php @@ -13,9 +13,9 @@ use Wikibase\DiffChange; use Wikibase\Entity; use Wikibase\EntityChange; -use Wikibase\Lib\Changes\EntityChangeFactory; use Wikibase\EntityFactory; use Wikibase\Item; +use Wikibase\Lib\Changes\EntityChangeFactory; use Wikibase\Property; use Wikibase\PropertyNoValueSnak; diff --git a/lib/tests/phpunit/entity/EntityFactoryTest.php b/lib/tests/phpunit/entity/EntityFactoryTest.php index da5e4e1..a634e46 100644 --- a/lib/tests/phpunit/entity/EntityFactoryTest.php +++ b/lib/tests/phpunit/entity/EntityFactoryTest.php @@ -2,9 +2,9 @@ namespace Wikibase\Test; -use Wikibase\EntityFactory; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\Property; +use Wikibase\EntityFactory; /** * @covers Wikibase\EntityFactory diff --git a/lib/tests/phpunit/formatters/EntityIdLabelFormatterTest.php b/lib/tests/phpunit/formatters/EntityIdLabelFormatterTest.php index 7275397..3570ae2 100644 --- a/lib/tests/phpunit/formatters/EntityIdLabelFormatterTest.php +++ b/lib/tests/phpunit/formatters/EntityIdLabelFormatterTest.php @@ -12,7 +12,6 @@ use Wikibase\LanguageFallbackChainFactory; use Wikibase\Lib\EntityIdLabelFormatter; use Wikibase\Lib\Store\EntityRedirect; -use Wikibase\Lib\Store\RedirectResolvingEntityLookup; /** * @covers Wikibase\Lib\EntityIdLabelFormatter diff --git a/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php b/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php index c28df04..058696a 100644 --- a/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php +++ b/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php @@ -3,7 +3,6 @@ namespace Wikibase\Lib\Parsers\Test; use Language; -use ValueParsers\ParserOptions; use Wikibase\Lib\Parsers\MonthNameUnlocalizer; /** diff --git a/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php b/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php index 284b44b..a465ebf 100644 --- a/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php +++ b/lib/tests/phpunit/serializers/DataModelSerializationRoundtripTest.php @@ -22,7 +22,6 @@ use Wikibase\DataModel\Snak\PropertyNoValueSnak; use Wikibase\DataModel\Snak\PropertySomeValueSnak; use Wikibase\DataModel\Snak\PropertyValueSnak; -use Wikibase\DataModel\Snak\Snak; use Wikibase\DataModel\Snak\SnakList; use Wikibase\Lib\Serializers\SerializationOptions; diff --git a/lib/tests/phpunit/serializers/DispatchingEntitySerializerTest.php b/lib/tests/phpunit/serializers/DispatchingEntitySerializerTest.php index 6998b4a..3319e0a 100644 --- a/lib/tests/phpunit/serializers/DispatchingEntitySerializerTest.php +++ b/lib/tests/phpunit/serializers/DispatchingEntitySerializerTest.php @@ -2,14 +2,14 @@ namespace Wikibase\Test; -use Wikibase\DataModel\Entity\ItemId; -use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\DataModel\SiteLink; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\Item; +use Wikibase\DataModel\Entity\ItemId; +use Wikibase\DataModel\Entity\Property; +use Wikibase\DataModel\Entity\PropertyId; +use Wikibase\DataModel\SiteLink; use Wikibase\Lib\Serializers\ItemSerializer; use Wikibase\Lib\Serializers\SerializerFactory; -use Wikibase\DataModel\Entity\Property; /** * @covers Wikibase\Lib\Serializers\DispatchingEntitySerializer diff --git a/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php b/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php index 4bd0f39..c2eb039 100644 --- a/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php +++ b/lib/tests/phpunit/serializers/LegacyInternalEntitySerializerTest.php @@ -4,7 +4,6 @@ use DataValues\Serializers\DataValueSerializer; use RuntimeException; -use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\InternalSerialization\SerializerFactory; diff --git a/lib/tests/phpunit/store/CachingEntityRevisionLookupTest.php b/lib/tests/phpunit/store/CachingEntityRevisionLookupTest.php index d00c6a2..06e81a1 100644 --- a/lib/tests/phpunit/store/CachingEntityRevisionLookupTest.php +++ b/lib/tests/phpunit/store/CachingEntityRevisionLookupTest.php @@ -4,9 +4,9 @@ use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\EntityRevision; use Wikibase\Lib\Store\CachingEntityRevisionLookup; +use Wikibase\Lib\Store\EntityLookup; use Wikibase\Lib\Store\EntityRedirect; use Wikibase\Lib\Store\UnresolvedRedirectException; diff --git a/lib/tests/phpunit/store/ItemUsageIndexTest.php b/lib/tests/phpunit/store/ItemUsageIndexTest.php index 6cbf903..22c908c 100644 --- a/lib/tests/phpunit/store/ItemUsageIndexTest.php +++ b/lib/tests/phpunit/store/ItemUsageIndexTest.php @@ -4,9 +4,9 @@ use MediaWikiSite; use Site; +use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\SiteLink; -use Wikibase\DataModel\Entity\Item; use Wikibase\ItemUsageIndex; /** diff --git a/lib/tests/phpunit/store/SiteLinkTableTest.php b/lib/tests/phpunit/store/SiteLinkTableTest.php index 505ab4a..51eb346 100644 --- a/lib/tests/phpunit/store/SiteLinkTableTest.php +++ b/lib/tests/phpunit/store/SiteLinkTableTest.php @@ -2,9 +2,9 @@ namespace Wikibase\Test; +use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\SiteLink; -use Wikibase\DataModel\Entity\Item; use Wikibase\Lib\Store\SiteLinkTable; /** -- To view, visit https://gerrit.wikimedia.org/r/153608 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2ae11c8e1fb6e47a1b5b1a3d30c6cb6fe339392 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
