Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/153611
Change subject: Optimized repo imports ...................................................................... Optimized repo imports Change-Id: I051a6a18a94bd5a679c9c479b51f32f9c8223e5c --- M repo/includes/ChangeOp/ChangeOpAliases.php M repo/includes/ChangeOp/ChangeOpDescription.php M repo/includes/ChangeOp/ChangeOpLabel.php M repo/includes/ClaimDiffer.php M repo/includes/Interactors/RedirectCreationInteractor.php M repo/includes/ItemView.php M repo/includes/LinkedData/EntityDataRequestHandler.php M repo/includes/LinkedData/EntityDataSerializationService.php M repo/includes/SummaryFormatter.php M repo/includes/UpdateRepoOnMoveJob.php M repo/includes/View/TermBoxView.php M repo/includes/WikibaseRepo.php M repo/includes/specials/SpecialGoToLinkedPage.php M repo/includes/specials/SpecialItemByTitle.php M repo/includes/specials/SpecialItemDisambiguation.php M repo/includes/store/sql/EntityPerPageBuilder.php M repo/includes/store/sql/PropertyInfoTableBuilder.php M repo/includes/store/sql/SqlStore.php M repo/maintenance/importInterlang.php M repo/maintenance/importProperties.php M repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php M repo/tests/phpunit/includes/EntityDiffVisualizerTest.php M repo/tests/phpunit/includes/EntityViewPlaceholderExpanderTest.php M repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php M repo/tests/phpunit/includes/ItemMoveTest.php M repo/tests/phpunit/includes/ItemSearchTextGeneratorTest.php M repo/tests/phpunit/includes/LinkedData/EntityDataTestProvider.php M repo/tests/phpunit/includes/Localizer/ChangeOpValidationExceptionLocalizerTest.php M repo/tests/phpunit/includes/UpdateRepoOnMoveJobTest.php M repo/tests/phpunit/includes/View/SiteLinksViewTest.php M repo/tests/phpunit/includes/actions/EditEntityActionTest.php M repo/tests/phpunit/includes/api/AvailableBadgesTest.php M repo/tests/phpunit/includes/api/BotEditTest.php M repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php M repo/tests/phpunit/includes/api/IntegrationApiTest.php M repo/tests/phpunit/includes/api/WikibaseApiTestCase.php M repo/tests/phpunit/includes/content/EntityContentDiffTest.php M repo/tests/phpunit/includes/content/EntityContentFactoryTest.php M repo/tests/phpunit/includes/content/EntityContentTest.php M repo/tests/phpunit/includes/content/EntityHandlerTest.php M repo/tests/phpunit/includes/content/ItemHandlerTest.php M repo/tests/phpunit/includes/content/PropertyContentTest.php M repo/tests/phpunit/includes/content/PropertyHandlerTest.php M repo/tests/phpunit/includes/specials/SpecialGoToLinkedPageTest.php M repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php M repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php M repo/tests/phpunit/includes/store/WikiPageEntityRevisionLookupTest.php M repo/tests/phpunit/includes/store/sql/ItemsPerSiteBuilderTest.php M repo/tests/phpunit/includes/store/sql/SqlIdGeneratorTest.php M repo/tests/phpunit/includes/store/sql/TermSqlIndexTest.php M repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php 51 files changed, 44 insertions(+), 85 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/11/153611/1 diff --git a/repo/includes/ChangeOp/ChangeOpAliases.php b/repo/includes/ChangeOp/ChangeOpAliases.php index f33d6c7..0e386da 100644 --- a/repo/includes/ChangeOp/ChangeOpAliases.php +++ b/repo/includes/ChangeOp/ChangeOpAliases.php @@ -5,7 +5,6 @@ use InvalidArgumentException; use ValueValidators\Result; use Wikibase\DataModel\Entity\Entity; -use Wikibase\DataModel\Term\AliasGroup; use Wikibase\DataModel\Term\Fingerprint; use Wikibase\Summary; use Wikibase\Validators\TermValidatorFactory; diff --git a/repo/includes/ChangeOp/ChangeOpDescription.php b/repo/includes/ChangeOp/ChangeOpDescription.php index 945d7ee..673014a 100644 --- a/repo/includes/ChangeOp/ChangeOpDescription.php +++ b/repo/includes/ChangeOp/ChangeOpDescription.php @@ -6,8 +6,6 @@ use ValueValidators\Result; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Term\Fingerprint; -use Wikibase\DataModel\Term\Term; -use Wikibase\DataModel\Term\TermList; use Wikibase\Summary; use Wikibase\Validators\TermValidatorFactory; diff --git a/repo/includes/ChangeOp/ChangeOpLabel.php b/repo/includes/ChangeOp/ChangeOpLabel.php index 4db4755..f053425 100644 --- a/repo/includes/ChangeOp/ChangeOpLabel.php +++ b/repo/includes/ChangeOp/ChangeOpLabel.php @@ -6,7 +6,6 @@ use ValueValidators\Result; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Term\Fingerprint; -use Wikibase\DataModel\Term\Term; use Wikibase\Summary; use Wikibase\Validators\TermValidatorFactory; diff --git a/repo/includes/ClaimDiffer.php b/repo/includes/ClaimDiffer.php index 420aca9..bd01646 100644 --- a/repo/includes/ClaimDiffer.php +++ b/repo/includes/ClaimDiffer.php @@ -2,8 +2,8 @@ namespace Wikibase; -use Diff\DiffOp\Diff\Diff; use Diff\Differ\Differ; +use Diff\DiffOp\Diff\Diff; use Diff\DiffOp\DiffOpChange; /** diff --git a/repo/includes/Interactors/RedirectCreationInteractor.php b/repo/includes/Interactors/RedirectCreationInteractor.php index cebf128..762d82c 100644 --- a/repo/includes/Interactors/RedirectCreationInteractor.php +++ b/repo/includes/Interactors/RedirectCreationInteractor.php @@ -2,7 +2,6 @@ namespace Wikibase\Repo\Interactors; -use Status; use User; use Wikibase\DataModel\Entity\EntityId; use Wikibase\EntityPermissionChecker; diff --git a/repo/includes/ItemView.php b/repo/includes/ItemView.php index ec4f80d..55b746f 100644 --- a/repo/includes/ItemView.php +++ b/repo/includes/ItemView.php @@ -2,8 +2,8 @@ namespace Wikibase; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Repo\View\SiteLinksView; +use Wikibase\Repo\WikibaseRepo; /** * Class for creating views for Wikibase\Item instances. diff --git a/repo/includes/LinkedData/EntityDataRequestHandler.php b/repo/includes/LinkedData/EntityDataRequestHandler.php index a89b6f8..8d180da 100644 --- a/repo/includes/LinkedData/EntityDataRequestHandler.php +++ b/repo/includes/LinkedData/EntityDataRequestHandler.php @@ -12,9 +12,9 @@ use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Entity\EntityIdParsingException; use Wikibase\EntityRevision; +use Wikibase\EntityTitleLookup; use Wikibase\Lib\Store\EntityRedirectResolvingDecorator; use Wikibase\Lib\Store\EntityRevisionLookup; -use Wikibase\EntityTitleLookup; use Wikibase\Lib\Store\StorageException; /** diff --git a/repo/includes/LinkedData/EntityDataSerializationService.php b/repo/includes/LinkedData/EntityDataSerializationService.php index cfb35a5..5bc6ac4 100644 --- a/repo/includes/LinkedData/EntityDataSerializationService.php +++ b/repo/includes/LinkedData/EntityDataSerializationService.php @@ -13,11 +13,11 @@ use RequestContext; use SiteList; use Wikibase\Api\ResultBuilder; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\EntityRevision; use Wikibase\EntityTitleLookup; use Wikibase\Lib\Serializers\SerializationOptions; use Wikibase\Lib\Serializers\SerializerFactory; +use Wikibase\Lib\Store\EntityLookup; use Wikibase\RdfSerializer; /** diff --git a/repo/includes/SummaryFormatter.php b/repo/includes/SummaryFormatter.php index 4164b98..1ab7edf 100644 --- a/repo/includes/SummaryFormatter.php +++ b/repo/includes/SummaryFormatter.php @@ -8,7 +8,6 @@ use Language; use MWException; use ValueFormatters\ValueFormatter; -use Wikibase\DataModel\Entity\BasicEntityIdParser; use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Entity\EntityIdParsingException; use Wikibase\Lib\EntityIdFormatter; diff --git a/repo/includes/UpdateRepoOnMoveJob.php b/repo/includes/UpdateRepoOnMoveJob.php index dea5cf2..1e527f0 100644 --- a/repo/includes/UpdateRepoOnMoveJob.php +++ b/repo/includes/UpdateRepoOnMoveJob.php @@ -10,9 +10,9 @@ use Wikibase\DataModel\Entity\ItemId; use Wikibase\DataModel\SiteLink; use Wikibase\Lib\Store\EntityRevisionLookup; +use Wikibase\Lib\Store\EntityStore; use Wikibase\Lib\Store\StorageException; use Wikibase\Repo\WikibaseRepo; -use Wikibase\Lib\Store\EntityStore; /** * Job for updating the repo after a page on the client has been moved. diff --git a/repo/includes/View/TermBoxView.php b/repo/includes/View/TermBoxView.php index bd3f1d4..1f30162 100644 --- a/repo/includes/View/TermBoxView.php +++ b/repo/includes/View/TermBoxView.php @@ -4,7 +4,6 @@ use Language; use Message; -use SpecialPage; use Title; use Wikibase\DataModel\Entity\Entity; use Wikibase\Utils; diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php index 2f23620..4f431fa 100644 --- a/repo/includes/WikibaseRepo.php +++ b/repo/includes/WikibaseRepo.php @@ -14,11 +14,6 @@ use StubObject; use ValueFormatters\FormatterOptions; use ValueFormatters\ValueFormatter; -use Wikibase\ItemHandler; -use Wikibase\PropertyHandler; -use Wikibase\Repo\Notifications\ChangeNotifier; -use Wikibase\Repo\Notifications\ChangeTransmitter; -use Wikibase\Repo\Notifications\DatabaseChangeTransmitter; use Wikibase\ChangeOp\ChangeOpFactoryProvider; use Wikibase\DataModel\Claim\ClaimGuidParser; use Wikibase\DataModel\Entity\BasicEntityIdParser; @@ -26,14 +21,14 @@ use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\Property; -use Wikibase\Lib\Changes\EntityChangeFactory; use Wikibase\EntityContentFactory; +use Wikibase\EntityFactory; use Wikibase\InternalSerialization\DeserializerFactory; use Wikibase\InternalSerialization\SerializerFactory; -use Wikibase\Lib\Store\EntityLookup; -use Wikibase\EntityFactory; +use Wikibase\ItemHandler; use Wikibase\LabelDescriptionDuplicateDetector; use Wikibase\LanguageFallbackChainFactory; +use Wikibase\Lib\Changes\EntityChangeFactory; use Wikibase\Lib\ClaimGuidGenerator; use Wikibase\Lib\ClaimGuidValidator; use Wikibase\Lib\DispatchingValueFormatter; @@ -50,14 +45,19 @@ use Wikibase\Lib\PropertyInfoDataTypeLookup; use Wikibase\Lib\SnakConstructionService; use Wikibase\Lib\SnakFormatter; +use Wikibase\Lib\Store\EntityContentDataCodec; +use Wikibase\Lib\Store\EntityLookup; use Wikibase\Lib\WikibaseDataTypeBuilders; use Wikibase\Lib\WikibaseSnakFormatterBuilders; use Wikibase\Lib\WikibaseValueFormatterBuilders; -use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\ParserOutputJsConfigBuilder; +use Wikibase\PropertyHandler; use Wikibase\ReferencedEntitiesFinder; use Wikibase\Repo\Localizer\ChangeOpValidationExceptionLocalizer; use Wikibase\Repo\Localizer\MessageParameterFormatter; +use Wikibase\Repo\Notifications\ChangeNotifier; +use Wikibase\Repo\Notifications\ChangeTransmitter; +use Wikibase\Repo\Notifications\DatabaseChangeTransmitter; use Wikibase\Repo\Notifications\DummyChangeTransmitter; use Wikibase\Settings; use Wikibase\SettingsArray; diff --git a/repo/includes/specials/SpecialGoToLinkedPage.php b/repo/includes/specials/SpecialGoToLinkedPage.php index 188ebe9..37bbb01 100644 --- a/repo/includes/specials/SpecialGoToLinkedPage.php +++ b/repo/includes/specials/SpecialGoToLinkedPage.php @@ -2,12 +2,12 @@ namespace Wikibase\Repo\Specials; -use InvalidArgumentException; use Html; +use InvalidArgumentException; use SiteStore; use Wikibase\DataModel\Entity\ItemId; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Lib\Store\SiteLinkLookup; +use Wikibase\Repo\WikibaseRepo; /** * Enables accessing a linked page on a site by providing the item id and site diff --git a/repo/includes/specials/SpecialItemByTitle.php b/repo/includes/specials/SpecialItemByTitle.php index c6b3f97..65068be 100644 --- a/repo/includes/specials/SpecialItemByTitle.php +++ b/repo/includes/specials/SpecialItemByTitle.php @@ -7,8 +7,8 @@ use SiteStore; use Wikibase\EntityTitleLookup; use Wikibase\ItemHandler; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Lib\Store\SiteLinkLookup; +use Wikibase\Repo\WikibaseRepo; /** * Enables accessing items by providing the identifier of a site and the title diff --git a/repo/includes/specials/SpecialItemDisambiguation.php b/repo/includes/specials/SpecialItemDisambiguation.php index 8fb919b..0150c29 100644 --- a/repo/includes/specials/SpecialItemDisambiguation.php +++ b/repo/includes/specials/SpecialItemDisambiguation.php @@ -7,7 +7,6 @@ use ValueFormatters\FormatterOptions; use ValueFormatters\ValueFormatter; use Wikibase\DataModel\Entity\Item; -use Wikibase\DataModel\Entity\ItemId; use Wikibase\EntityTitleLookup; use Wikibase\ItemDisambiguation; use Wikibase\Lib\EntityIdHtmlLinkFormatter; diff --git a/repo/includes/store/sql/EntityPerPageBuilder.php b/repo/includes/store/sql/EntityPerPageBuilder.php index 48a5ac5..f3e7e52 100644 --- a/repo/includes/store/sql/EntityPerPageBuilder.php +++ b/repo/includes/store/sql/EntityPerPageBuilder.php @@ -1,9 +1,9 @@ <?php namespace Wikibase; -use Wikibase\Lib\Reporting\MessageReporter; use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\DataModel\Entity\EntityIdParsingException; +use Wikibase\Lib\Reporting\MessageReporter; /** * Utility class for rebuilding the wb_entity_per_page table. diff --git a/repo/includes/store/sql/PropertyInfoTableBuilder.php b/repo/includes/store/sql/PropertyInfoTableBuilder.php index 092e9c8..00abf99 100644 --- a/repo/includes/store/sql/PropertyInfoTableBuilder.php +++ b/repo/includes/store/sql/PropertyInfoTableBuilder.php @@ -2,8 +2,8 @@ namespace Wikibase; -use Wikibase\Lib\Reporting\MessageReporter; use Wikibase\DataModel\Entity\PropertyId; +use Wikibase\Lib\Reporting\MessageReporter; use Wikibase\Lib\Store\EntityLookup; /** diff --git a/repo/includes/store/sql/SqlStore.php b/repo/includes/store/sql/SqlStore.php index 8536947..ee2b3a0 100644 --- a/repo/includes/store/sql/SqlStore.php +++ b/repo/includes/store/sql/SqlStore.php @@ -10,7 +10,6 @@ use ObjectCache; use Revision; use Wikibase\Lib\Reporting\ObservableMessageReporter; -use Wikibase\DataModel\Entity\BasicEntityIdParser; use Wikibase\Lib\Store\CachingEntityRevisionLookup; use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\Lib\Store\EntityInfoBuilderFactory; @@ -18,13 +17,12 @@ use Wikibase\Lib\Store\EntityRevisionLookup; use Wikibase\Lib\Store\EntityStore; use Wikibase\Lib\Store\EntityStoreWatcher; -use Wikibase\Lib\Store\RevisionBasedEntityLookup; use Wikibase\Lib\Store\RedirectResolvingEntityLookup; +use Wikibase\Lib\Store\RevisionBasedEntityLookup; use Wikibase\Lib\Store\SiteLinkCache; use Wikibase\Lib\Store\SiteLinkTable; use Wikibase\Lib\Store\Sql\SqlEntityInfoBuilderFactory; use Wikibase\Lib\Store\WikiPageEntityRevisionLookup; -use Wikibase\Lib\Test\Store\RedirectResolvingEntityLookupTest; use Wikibase\Repo\Store\DispatchingEntityStoreWatcher; use Wikibase\Repo\Store\WikiPageEntityStore; use Wikibase\Repo\WikibaseRepo; diff --git a/repo/maintenance/importInterlang.php b/repo/maintenance/importInterlang.php index 75d555b..d66b9be 100644 --- a/repo/maintenance/importInterlang.php +++ b/repo/maintenance/importInterlang.php @@ -15,8 +15,8 @@ */ use Wikibase\DataModel\SiteLink; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Lib\Store\EntityStore; +use Wikibase\Repo\WikibaseRepo; $basePath = getenv( 'MW_INSTALL_PATH' ) !== false ? getenv( 'MW_INSTALL_PATH' ) : __DIR__ . '/../../../..'; diff --git a/repo/maintenance/importProperties.php b/repo/maintenance/importProperties.php index cfd9db9..9f185f3 100644 --- a/repo/maintenance/importProperties.php +++ b/repo/maintenance/importProperties.php @@ -1,8 +1,8 @@ <?php use Wikibase\DataModel\Entity\Property; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Lib\Store\EntityStore; +use Wikibase\Repo\WikibaseRepo; /** * Maintenance script for importing properties in Wikidata. diff --git a/repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php b/repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php index 112ba11..d897c1e 100644 --- a/repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php +++ b/repo/tests/phpunit/includes/ClaimHtmlGeneratorTest.php @@ -13,9 +13,9 @@ use Wikibase\PropertyValueSnak; use Wikibase\Reference; use Wikibase\ReferenceList; +use Wikibase\Repo\View\SnakHtmlGenerator; use Wikibase\SnakList; use Wikibase\Statement; -use Wikibase\Repo\View\SnakHtmlGenerator; /** * @covers Wikibase\ClaimHtmlGenerator diff --git a/repo/tests/phpunit/includes/EntityDiffVisualizerTest.php b/repo/tests/phpunit/includes/EntityDiffVisualizerTest.php index fb6120f..95002b0 100644 --- a/repo/tests/phpunit/includes/EntityDiffVisualizerTest.php +++ b/repo/tests/phpunit/includes/EntityDiffVisualizerTest.php @@ -10,9 +10,9 @@ use Site; use Wikibase\ClaimDiffer; use Wikibase\ClaimDifferenceVisualizer; -use Wikibase\Repo\Content\EntityContentDiff; use Wikibase\DataModel\Entity\EntityDiff; use Wikibase\EntityDiffVisualizer; +use Wikibase\Repo\Content\EntityContentDiff; /** * @covers Wikibase\EntityDiffVisualizer diff --git a/repo/tests/phpunit/includes/EntityViewPlaceholderExpanderTest.php b/repo/tests/phpunit/includes/EntityViewPlaceholderExpanderTest.php index cd9617e..32b01f5 100644 --- a/repo/tests/phpunit/includes/EntityViewPlaceholderExpanderTest.php +++ b/repo/tests/phpunit/includes/EntityViewPlaceholderExpanderTest.php @@ -8,8 +8,8 @@ use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\EntityRevision; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\EntityViewPlaceholderExpander; +use Wikibase\Lib\Store\EntityLookup; use Wikibase\Lib\Store\EntityRevisionLookup; use Wikibase\Lib\Store\StorageException; diff --git a/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php b/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php index bf6192e..c4a2e71 100644 --- a/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php +++ b/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php @@ -14,7 +14,6 @@ use Wikibase\Repo\Interactors\RedirectCreationException; use Wikibase\Repo\Interactors\RedirectCreationInteractor; use Wikibase\Repo\WikibaseRepo; -use Wikibase\Summary; use Wikibase\Test\MockRepository; /** diff --git a/repo/tests/phpunit/includes/ItemMoveTest.php b/repo/tests/phpunit/includes/ItemMoveTest.php index 2624a0c..57edb31 100644 --- a/repo/tests/phpunit/includes/ItemMoveTest.php +++ b/repo/tests/phpunit/includes/ItemMoveTest.php @@ -2,7 +2,6 @@ namespace Wikibase\Test; -use TestSites; use Title; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; diff --git a/repo/tests/phpunit/includes/ItemSearchTextGeneratorTest.php b/repo/tests/phpunit/includes/ItemSearchTextGeneratorTest.php index 6325831..efcfa45 100644 --- a/repo/tests/phpunit/includes/ItemSearchTextGeneratorTest.php +++ b/repo/tests/phpunit/includes/ItemSearchTextGeneratorTest.php @@ -2,8 +2,8 @@ namespace Wikibase\Test; -use Wikibase\DataModel\SiteLink; use Wikibase\DataModel\Entity\Item; +use Wikibase\DataModel\SiteLink; use Wikibase\Repo\ItemSearchTextGenerator; /** diff --git a/repo/tests/phpunit/includes/LinkedData/EntityDataTestProvider.php b/repo/tests/phpunit/includes/LinkedData/EntityDataTestProvider.php index 1eb2dff..5ea49a4 100644 --- a/repo/tests/phpunit/includes/LinkedData/EntityDataTestProvider.php +++ b/repo/tests/phpunit/includes/LinkedData/EntityDataTestProvider.php @@ -2,9 +2,9 @@ namespace Wikibase\Test; +use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\EntityRevision; -use Wikibase\DataModel\Entity\Item; use Wikibase\Lib\Store\EntityRedirect; /** diff --git a/repo/tests/phpunit/includes/Localizer/ChangeOpValidationExceptionLocalizerTest.php b/repo/tests/phpunit/includes/Localizer/ChangeOpValidationExceptionLocalizerTest.php index d8a2cfc..4967072 100644 --- a/repo/tests/phpunit/includes/Localizer/ChangeOpValidationExceptionLocalizerTest.php +++ b/repo/tests/phpunit/includes/Localizer/ChangeOpValidationExceptionLocalizerTest.php @@ -4,12 +4,10 @@ use Exception; use ValueFormatters\ValueFormatter; -use ValueParsers\ParseException; use ValueValidators\Error; use ValueValidators\Result; use Wikibase\ChangeOp\ChangeOpValidationException; use Wikibase\Repo\Localizer\ChangeOpValidationExceptionLocalizer; -use Wikibase\Repo\Localizer\MessageParameterFormatter; /** * @covers Wikibase\Repo\Localizer\ChangeOpValidationExceptionLocalizer diff --git a/repo/tests/phpunit/includes/UpdateRepoOnMoveJobTest.php b/repo/tests/phpunit/includes/UpdateRepoOnMoveJobTest.php index 6d37dbc..4d39d1d 100644 --- a/repo/tests/phpunit/includes/UpdateRepoOnMoveJobTest.php +++ b/repo/tests/phpunit/includes/UpdateRepoOnMoveJobTest.php @@ -4,12 +4,11 @@ use Title; use User; -use TestSites; -use Wikibase\UpdateRepoOnMoveJob; -use Wikibase\Repo\WikibaseRepo; use Wikibase\DataModel\Entity\Item; -use Wikibase\Repo\Store\WikiPageEntityStore; use Wikibase\EntityPerPageTable; +use Wikibase\Repo\Store\WikiPageEntityStore; +use Wikibase\Repo\WikibaseRepo; +use Wikibase\UpdateRepoOnMoveJob; /** * @covers Wikibase\UpdateRepoOnMoveJob diff --git a/repo/tests/phpunit/includes/View/SiteLinksViewTest.php b/repo/tests/phpunit/includes/View/SiteLinksViewTest.php index 963aba5..2f79021 100644 --- a/repo/tests/phpunit/includes/View/SiteLinksViewTest.php +++ b/repo/tests/phpunit/includes/View/SiteLinksViewTest.php @@ -10,8 +10,8 @@ use Wikibase\DataModel\SiteLink; use Wikibase\Lib\Store\EntityLookup; use Wikibase\Repo\View\SectionEditLinkGenerator; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Repo\View\SiteLinksView; +use Wikibase\Repo\WikibaseRepo; /** * @covers Wikibase\Repo\View\SiteLinksView diff --git a/repo/tests/phpunit/includes/actions/EditEntityActionTest.php b/repo/tests/phpunit/includes/actions/EditEntityActionTest.php index 29f4c29..a037291 100644 --- a/repo/tests/phpunit/includes/actions/EditEntityActionTest.php +++ b/repo/tests/phpunit/includes/actions/EditEntityActionTest.php @@ -3,7 +3,6 @@ namespace Wikibase\Test; use MWException; -use TestSites; use Title; use User; use Wikibase\NamespaceUtils; diff --git a/repo/tests/phpunit/includes/api/AvailableBadgesTest.php b/repo/tests/phpunit/includes/api/AvailableBadgesTest.php index f1b416e..d956541 100644 --- a/repo/tests/phpunit/includes/api/AvailableBadgesTest.php +++ b/repo/tests/phpunit/includes/api/AvailableBadgesTest.php @@ -2,7 +2,6 @@ namespace Wikibase\Test\Api; -use ApiTestCase; use Wikibase\Repo\WikibaseRepo; /** diff --git a/repo/tests/phpunit/includes/api/BotEditTest.php b/repo/tests/phpunit/includes/api/BotEditTest.php index adf34d6..81ca2f5 100644 --- a/repo/tests/phpunit/includes/api/BotEditTest.php +++ b/repo/tests/phpunit/includes/api/BotEditTest.php @@ -2,8 +2,6 @@ namespace Wikibase\Test\Api; -use ApiTestCase; -use TestUser; use Title; use Wikibase\NamespaceUtils; diff --git a/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php b/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php index 6e7702d..f9fc566 100644 --- a/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php +++ b/repo/tests/phpunit/includes/api/ClaimModificationHelperTest.php @@ -5,7 +5,6 @@ use ApiMain; use DataValues\StringValue; use UsageException; -use ValueFormatters\ValueFormatter; use Wikibase\Api\ApiErrorReporter; use Wikibase\Api\ClaimModificationHelper; use Wikibase\Api\CreateClaim; diff --git a/repo/tests/phpunit/includes/api/IntegrationApiTest.php b/repo/tests/phpunit/includes/api/IntegrationApiTest.php index 4f6e25d..013e29f 100644 --- a/repo/tests/phpunit/includes/api/IntegrationApiTest.php +++ b/repo/tests/phpunit/includes/api/IntegrationApiTest.php @@ -2,8 +2,6 @@ namespace Wikibase\Test\Api; -use ApiTestCase; -use TestSites; use Wikibase\Repo\WikibaseRepo; /** diff --git a/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php b/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php index 6ec30e8..f159e27 100644 --- a/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php +++ b/repo/tests/phpunit/includes/api/WikibaseApiTestCase.php @@ -2,10 +2,7 @@ namespace Wikibase\Test\Api; -use ApiTestCase; use Revision; -use TestSites; -use TestUser; use UsageException; use User; use Wikibase\EntityFactory; diff --git a/repo/tests/phpunit/includes/content/EntityContentDiffTest.php b/repo/tests/phpunit/includes/content/EntityContentDiffTest.php index bfca7a7..e1e40ba 100644 --- a/repo/tests/phpunit/includes/content/EntityContentDiffTest.php +++ b/repo/tests/phpunit/includes/content/EntityContentDiffTest.php @@ -5,9 +5,8 @@ use Diff\DiffOp\Diff\Diff; use Diff\DiffOp\DiffOpAdd; use Diff\DiffOp\DiffOpRemove; -use MediaWikiTestCase; -use Wikibase\Repo\Content\EntityContentDiff; use Wikibase\DataModel\Entity\EntityDiff; +use Wikibase\Repo\Content\EntityContentDiff; /** * @covers Wikibase\Repo\Content\EntityContentDiff diff --git a/repo/tests/phpunit/includes/content/EntityContentFactoryTest.php b/repo/tests/phpunit/includes/content/EntityContentFactoryTest.php index a5e7a27..2f0f211 100644 --- a/repo/tests/phpunit/includes/content/EntityContentFactoryTest.php +++ b/repo/tests/phpunit/includes/content/EntityContentFactoryTest.php @@ -2,6 +2,7 @@ namespace Wikibase\Test; +use ContentHandler; use Wikibase\DataModel\Entity\Entity; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; @@ -10,7 +11,6 @@ use Wikibase\EntityContentFactory; use Wikibase\Lib\Store\EntityRedirect; use Wikibase\Repo\WikibaseRepo; -use ContentHandler; /** * @covers Wikibase\EntityContentFactory diff --git a/repo/tests/phpunit/includes/content/EntityContentTest.php b/repo/tests/phpunit/includes/content/EntityContentTest.php index e175c59..e067385 100644 --- a/repo/tests/phpunit/includes/content/EntityContentTest.php +++ b/repo/tests/phpunit/includes/content/EntityContentTest.php @@ -10,14 +10,14 @@ use Title; use Wikibase\DataModel\Claim\Statement; use Wikibase\DataModel\Entity\Entity; -use Wikibase\DataModel\Term\Term; -use Wikibase\Lib\Store\EntityRedirect; use Wikibase\DataModel\Entity\EntityDiff; -use Wikibase\DataModel\Snak\PropertyNoValueSnak; use Wikibase\DataModel\Entity\EntityId; +use Wikibase\DataModel\Snak\PropertyNoValueSnak; +use Wikibase\DataModel\Term\Term; use Wikibase\EntityContent; use Wikibase\LanguageFallbackChain; use Wikibase\LanguageWithConversion; +use Wikibase\Lib\Store\EntityRedirect; use Wikibase\Lib\Store\EntityStore; use Wikibase\Repo\Content\EntityContentDiff; use Wikibase\Repo\WikibaseRepo; diff --git a/repo/tests/phpunit/includes/content/EntityHandlerTest.php b/repo/tests/phpunit/includes/content/EntityHandlerTest.php index 4cdc3a0..58176d6 100644 --- a/repo/tests/phpunit/includes/content/EntityHandlerTest.php +++ b/repo/tests/phpunit/includes/content/EntityHandlerTest.php @@ -15,7 +15,6 @@ use Wikibase\InternalSerialization\SerializerFactory; use Wikibase\Lib\Serializers\LegacyInternalEntitySerializer; use Wikibase\Lib\Store\EntityRedirect; -use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\Repo\WikibaseRepo; use Wikibase\SettingsArray; diff --git a/repo/tests/phpunit/includes/content/ItemHandlerTest.php b/repo/tests/phpunit/includes/content/ItemHandlerTest.php index cd21434..590850e 100644 --- a/repo/tests/phpunit/includes/content/ItemHandlerTest.php +++ b/repo/tests/phpunit/includes/content/ItemHandlerTest.php @@ -10,9 +10,7 @@ use Wikibase\EntityContent; use Wikibase\ItemContent; use Wikibase\ItemHandler; -use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\Lib\Store\EntityRedirect; -use Wikibase\Repo\WikibaseRepo; use Wikibase\SettingsArray; /** diff --git a/repo/tests/phpunit/includes/content/PropertyContentTest.php b/repo/tests/phpunit/includes/content/PropertyContentTest.php index 9cf0804..9eb3453 100644 --- a/repo/tests/phpunit/includes/content/PropertyContentTest.php +++ b/repo/tests/phpunit/includes/content/PropertyContentTest.php @@ -4,7 +4,6 @@ use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\PropertyContent; /** * @covers Wikibase\PropertyContent diff --git a/repo/tests/phpunit/includes/content/PropertyHandlerTest.php b/repo/tests/phpunit/includes/content/PropertyHandlerTest.php index 2b83499..824b216 100644 --- a/repo/tests/phpunit/includes/content/PropertyHandlerTest.php +++ b/repo/tests/phpunit/includes/content/PropertyHandlerTest.php @@ -6,10 +6,8 @@ use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\Property; use Wikibase\DataModel\Entity\PropertyId; -use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\PropertyContent; use Wikibase\PropertyHandler; -use Wikibase\Repo\WikibaseRepo; use Wikibase\SettingsArray; /** diff --git a/repo/tests/phpunit/includes/specials/SpecialGoToLinkedPageTest.php b/repo/tests/phpunit/includes/specials/SpecialGoToLinkedPageTest.php index 8ea8e7b..577147d 100644 --- a/repo/tests/phpunit/includes/specials/SpecialGoToLinkedPageTest.php +++ b/repo/tests/phpunit/includes/specials/SpecialGoToLinkedPageTest.php @@ -5,9 +5,8 @@ use FauxResponse; use Site; use SiteStore; -use Wikibase\DataModel\Entity\ItemId; -use Wikibase\Repo\Specials\SpecialGoToLinkedPage; use Wikibase\Lib\Store\SiteLinkLookup; +use Wikibase\Repo\Specials\SpecialGoToLinkedPage; /** * @covers Wikibase\Repo\Specials\SpecialGoToLinkedPage diff --git a/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php b/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php index 6376e3c..67a93e4 100644 --- a/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php +++ b/repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php @@ -9,8 +9,8 @@ use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\ItemId; use Wikibase\EntityTitleLookup; -use Wikibase\Repo\Specials\SpecialItemByTitle; use Wikibase\Lib\Store\SiteLinkLookup; +use Wikibase\Repo\Specials\SpecialItemByTitle; /** * @covers Wikibase\Repo\Specials\SpecialItemByTitle diff --git a/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php b/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php index c1dc8b9..9557dc3 100644 --- a/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php +++ b/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php @@ -2,7 +2,6 @@ namespace Wikibase\Test; -use TestSites; use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\SiteLink; use Wikibase\Repo\Specials\SpecialSetSiteLink; diff --git a/repo/tests/phpunit/includes/store/WikiPageEntityRevisionLookupTest.php b/repo/tests/phpunit/includes/store/WikiPageEntityRevisionLookupTest.php index ab0d33e..b1d0172 100644 --- a/repo/tests/phpunit/includes/store/WikiPageEntityRevisionLookupTest.php +++ b/repo/tests/phpunit/includes/store/WikiPageEntityRevisionLookupTest.php @@ -2,18 +2,12 @@ namespace Wikibase\Test; -use DataValues\Deserializers\DataValueDeserializer; -use DataValues\Serializers\DataValueSerializer; -use Wikibase\DataModel\Entity\BasicEntityIdParser; use Wikibase\DataModel\Entity\Entity; use Wikibase\EntityRevision; -use Wikibase\InternalSerialization\DeserializerFactory; -use Wikibase\InternalSerialization\SerializerFactory; use Wikibase\Lib\Store\EntityLookup; use Wikibase\Lib\Store\EntityRedirect; -use Wikibase\Repo\WikibaseRepo; use Wikibase\Lib\Store\WikiPageEntityRevisionLookup; -use Wikibase\Lib\Store\EntityContentDataCodec; +use Wikibase\Repo\WikibaseRepo; /** * @covers Wikibase\Lib\Store\WikiPageEntityLookup diff --git a/repo/tests/phpunit/includes/store/sql/ItemsPerSiteBuilderTest.php b/repo/tests/phpunit/includes/store/sql/ItemsPerSiteBuilderTest.php index 13db70f..f58849c 100644 --- a/repo/tests/phpunit/includes/store/sql/ItemsPerSiteBuilderTest.php +++ b/repo/tests/phpunit/includes/store/sql/ItemsPerSiteBuilderTest.php @@ -5,8 +5,8 @@ use Wikibase\DataModel\Entity\Item; use Wikibase\DataModel\Entity\ItemId; use Wikibase\EntityIdPager; -use Wikibase\Lib\Store\EntityLookup; use Wikibase\ItemsPerSiteBuilder; +use Wikibase\Lib\Store\EntityLookup; use Wikibase\Lib\Store\SiteLinkTable; /** diff --git a/repo/tests/phpunit/includes/store/sql/SqlIdGeneratorTest.php b/repo/tests/phpunit/includes/store/sql/SqlIdGeneratorTest.php index c0fa483..adbfab2 100644 --- a/repo/tests/phpunit/includes/store/sql/SqlIdGeneratorTest.php +++ b/repo/tests/phpunit/includes/store/sql/SqlIdGeneratorTest.php @@ -4,7 +4,6 @@ use Wikibase\IdGenerator; use Wikibase\Repo\WikibaseRepo; -use Wikibase\StoreFactory; /** * @covers Wikibase\SqlIdGenerator diff --git a/repo/tests/phpunit/includes/store/sql/TermSqlIndexTest.php b/repo/tests/phpunit/includes/store/sql/TermSqlIndexTest.php index e6167ee..a0976ce 100644 --- a/repo/tests/phpunit/includes/store/sql/TermSqlIndexTest.php +++ b/repo/tests/phpunit/includes/store/sql/TermSqlIndexTest.php @@ -2,8 +2,8 @@ namespace Wikibase\Test; -use Wikibase\DataModel\SiteLink; use Wikibase\DataModel\Entity\Item; +use Wikibase\DataModel\SiteLink; use Wikibase\Repo\WikibaseRepo; use Wikibase\StringNormalizer; use Wikibase\Term; diff --git a/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php b/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php index 158239d..f0a9d0b 100644 --- a/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php +++ b/repo/tests/phpunit/includes/store/sql/WikiPageEntityStoreTest.php @@ -15,12 +15,12 @@ use Wikibase\EntityPerPageTable; use Wikibase\Lib\Store\EntityRedirect; use Wikibase\Lib\Store\EntityRevisionLookup; +use Wikibase\Lib\Store\EntityStore; +use Wikibase\Lib\Store\StorageException; +use Wikibase\Lib\Store\WikiPageEntityRevisionLookup; use Wikibase\Repo\Store\WikiPageEntityStore; use Wikibase\Repo\WikibaseRepo; use Wikibase\SqlIdGenerator; -use Wikibase\Lib\Store\StorageException; -use Wikibase\Lib\Store\EntityStore; -use Wikibase\Lib\Store\WikiPageEntityRevisionLookup; /** * @covers Wikibase\Repo\Store\WikiPageEntityStore -- To view, visit https://gerrit.wikimedia.org/r/153611 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I051a6a18a94bd5a679c9c479b51f32f9c8223e5c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
