IAlex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153638
Change subject: Fix undefined variable notice in
ResourceLoaderFileModule::getSkipFunction()
......................................................................
Fix undefined variable notice in ResourceLoaderFileModule::getSkipFunction()
Looking at the call chain of validateScriptFile() up to JSTokenzier, the first
parameter if the file name, otherwise "[inline]" is used; so that variable
should be $localPath.
Bug: 69214
Change-Id: If7f36449cb352f50ba795a6d306e5d949a3dbd29
---
M includes/resourceloader/ResourceLoaderFileModule.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/38/153638/1
diff --git a/includes/resourceloader/ResourceLoaderFileModule.php
b/includes/resourceloader/ResourceLoaderFileModule.php
index f646ae9..06f7146 100644
--- a/includes/resourceloader/ResourceLoaderFileModule.php
+++ b/includes/resourceloader/ResourceLoaderFileModule.php
@@ -479,7 +479,7 @@
}
$contents = file_get_contents( $localPath );
if ( $this->getConfig()->get( 'ResourceLoaderValidateStaticJS'
) ) {
- $contents = $this->validateScriptFile( $fileName,
$contents );
+ $contents = $this->validateScriptFile( $localPath,
$contents );
}
return $contents;
}
--
To view, visit https://gerrit.wikimedia.org/r/153638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7f36449cb352f50ba795a6d306e5d949a3dbd29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
