Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/153698
Change subject: Minor cleanup in SnaksFinder
......................................................................
Minor cleanup in SnaksFinder
Change-Id: Ibebb95f4e58560abe4b31cba2f8c546b906bc4f7
---
M client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/98/153698/1
diff --git a/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
b/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
index 28d5dbc..bf28fb5 100644
--- a/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
+++ b/client/includes/DataAccess/PropertyParserFunction/SnaksFinder.php
@@ -9,6 +9,7 @@
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\EntityIdParsingException;
use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Snak\Snak;
use Wikibase\Lib\PropertyLabelNotResolvedException;
use Wikibase\Lib\Store\EntityLookup;
use Wikibase\PropertyLabelResolver;
@@ -16,7 +17,7 @@
/**
* Find Snaks for claims in an entity, with EntityId, based on property label
or property id.
*
- * @fixme see what code can be shared with Lua handling code.
+ * TODO: see what code can be shared with Lua handling code.
*
* @since 0.5
*
@@ -42,8 +43,9 @@
/**
* @param EntityId $entityId
* @param string $propertyLabel
+ * @param string $languageCode
*
- * @fixme use SnakList instead of array of Snaks
+ * TODO: use SnakList instead of array of Snaks
*
* @return Snak[]
*/
--
To view, visit https://gerrit.wikimedia.org/r/153698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibebb95f4e58560abe4b31cba2f8c546b906bc4f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
