Snail has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154017

Change subject: Send email from $wgPasswordSender instead of user's email
......................................................................

Send email from $wgPasswordSender instead of user's email

This is to stop emails going to spam if an SPF record is set.

This is required for the extension to work on wikis hosted by sites with strict 
sender domain policies (like Dreamhost).

See: 
https://www.mediawiki.org/wiki/Thread:Extension_talk:InviteSignup/Sending_mails_from_users%27_addresses_is_not_a_great_idea

Change-Id: I1d39996697223966a7abbc40713df2aeb9ed3763

Send e-mail from  instead of users' e-mails

Change-Id: If495b325c228f7257117c460ff9e107aa0cc7082
---
M SpecialInviteSignup.php
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/InviteSignup 
refs/changes/17/154017/1

diff --git a/SpecialInviteSignup.php b/SpecialInviteSignup.php
index 8ff0e9e..82f8050 100644
--- a/SpecialInviteSignup.php
+++ b/SpecialInviteSignup.php
@@ -172,14 +172,16 @@
        }
 
        public static function sendInviteEmail( User $inviter, $email, $hash ) {
-               $url = Title::newFromText( 'Special:Userlogin/signup' 
)->getCanonicalUrl( array( 'invite' => $hash, 'returnto' => 'Special:Dashboard' 
) );
+        global $wgPasswordSender, $wgPasswordSenderName;
+        $emailFrom = new MailAddress( $wgPasswordSender, $wgPasswordSenderName 
);
+
+       $url = Title::newFromText( 'Special:Userlogin/signup' 
)->getCanonicalUrl( array( 'invite' => $hash, 'returnto' => 'Special:Dashboard' 
) );
 
                $subj = wfMessage( 'is-emailsubj' )->inContentLanguage();
                $body = wfMessage( 'is-emailbody' )
                        ->params( $inviter->getName(), $url )
                        ->inContentLanguage();
 
-               $emailFrom = new MailAddress( $inviter );
                $emailTo = new MailAddress( $email );
                $params = array(
                        'to' => $emailTo,

-- 
To view, visit https://gerrit.wikimedia.org/r/154017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If495b325c228f7257117c460ff9e107aa0cc7082
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/InviteSignup
Gerrit-Branch: master
Gerrit-Owner: Snail <sn...@solitarysnail.com>
Gerrit-Reviewer: Lewis Cawte <le...@lewiscawte.me>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to