Gergő Tisza has uploaded a new change for review.
https://gerrit.wikimedia.org/r/154269
Change subject: Fix failing loader tests
......................................................................
Fix failing loader tests
mw.notify calls mw.loader.using now, which we mock out in some
tests. This change adds an exception to the mock.
Change-Id: I68d7293a4d45f904e949ea4b56ec409456624cbd
---
M tests/qunit/mmv/mmv.bootstrap.test.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/69/154269/1
diff --git a/tests/qunit/mmv/mmv.bootstrap.test.js
b/tests/qunit/mmv/mmv.bootstrap.test.js
index 50f23ab..438d2cb 100644
--- a/tests/qunit/mmv/mmv.bootstrap.test.js
+++ b/tests/qunit/mmv/mmv.bootstrap.test.js
@@ -63,7 +63,9 @@
var bootstrap,
errorMessage = 'loading failed';
- this.sandbox.stub( mw.loader, 'using' ).callsArgWith( 2, new
Error( errorMessage, ['mmv'] ) );
+ this.sandbox.stub( mw.loader, 'using' )
+ .callsArgWith( 2, new Error( errorMessage, ['mmv'] ) )
+ .withArgs( 'mediawiki.notification' ).returns(
$.Deferred().reject() ); // needed for mw.notify
bootstrap = createBootstrap();
@@ -87,7 +89,9 @@
var event, returnValue,
bootstrap = new mw.mmv.MultimediaViewerBootstrap();
- this.sandbox.stub( mw.loader, 'using' ).callsArgWith( 2, new
Error( 'loading failed', ['mmv'] ) );
+ this.sandbox.stub( mw.loader, 'using' )
+ .callsArgWith( 2, new Error( 'loading failed', ['mmv']
) )
+ .withArgs( 'mediawiki.notification' ).returns(
$.Deferred().reject() ); // needed for mw.notify
event = new $.Event( 'click', { button: 0, which: 1 } );
returnValue = bootstrap.click( {}, event, 'foo' );
--
To view, visit https://gerrit.wikimedia.org/r/154269
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68d7293a4d45f904e949ea4b56ec409456624cbd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
