jenkins-bot has submitted this change and it was merged. Change subject: QA: Workaround for cookie domain bug in chrome webdriver ......................................................................
QA: Workaround for cookie domain bug in chrome webdriver Added a domain to the add_cookie call used by the "using the mobile site" step to avoid a bug where chrome complains of "optional 'domain' invalid" despite it being optional. Change-Id: I7134bbf3031a348e261a73fa354cd8e19ae11b85 --- M tests/browser/features/step_definitions/common_steps.rb 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: JGonera: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/common_steps.rb b/tests/browser/features/step_definitions/common_steps.rb index 79cfeb4..3fc7260 100644 --- a/tests/browser/features/step_definitions/common_steps.rb +++ b/tests/browser/features/step_definitions/common_steps.rb @@ -15,9 +15,12 @@ end Given(/^I am using the mobile site$/) do - visit(MainPage) - @browser.cookies.add 'mf_useformat', 'true' - on(MainPage).refresh + on(MainPage) do |page| + page.goto + # A domain is explicitly given to avoid a bug in earlier versions of Chrome + page.browser.cookies.add 'mf_useformat', 'true', domain: URI.parse(page.page_url_value).host + page.refresh + end end Given(/^I am on the sign-up page$/) do -- To view, visit https://gerrit.wikimedia.org/r/154217 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7134bbf3031a348e261a73fa354cd8e19ae11b85 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Dduvall <[email protected]> Gerrit-Reviewer: Awjrichards <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
