[MediaWiki-commits] [Gerrit] Use public instead of var in classes - change (mediawiki...DonationInterface)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/154596

Change subject: Use public instead of var in classes
......................................................................

Use public instead of var in classes

Change-Id: I88830925b6531ff74fab35e1fad9e83e09689f17
---
M extras/custom_filters/filters/minfraud/ccfd/src/CreditCardFraudDetection.php
M extras/custom_filters/filters/minfraud/ccfd/src/HTTPBase.php
M extras/custom_filters/filters/minfraud/ccfd/src/TelephoneVerification.php
M gateway_common/donation.api.php
M tests/includes/test_gateway/test.adapter.php
5 files changed, 20 insertions(+), 20 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/96/154596/1

diff --git 
a/extras/custom_filters/filters/minfraud/ccfd/src/CreditCardFraudDetection.php 
b/extras/custom_filters/filters/minfraud/ccfd/src/CreditCardFraudDetection.php
index 367c561..5b6b5ba 100644
--- 
a/extras/custom_filters/filters/minfraud/ccfd/src/CreditCardFraudDetection.php
+++ 
b/extras/custom_filters/filters/minfraud/ccfd/src/CreditCardFraudDetection.php
@@ -21,9 +21,9 @@
 
 require_once ("HTTPBase.php");
 class CreditCardFraudDetection extends HTTPBase {
-  var $server;
-  var $numservers;
-  var $API_VERSION;
+  public $server;
+  public $numservers;
+  public $API_VERSION;
 
   function CreditCardFraudDetection() {
     $this->HTTPBase();
diff --git a/extras/custom_filters/filters/minfraud/ccfd/src/HTTPBase.php 
b/extras/custom_filters/filters/minfraud/ccfd/src/HTTPBase.php
index 07531d8..cf24457 100644
--- a/extras/custom_filters/filters/minfraud/ccfd/src/HTTPBase.php
+++ b/extras/custom_filters/filters/minfraud/ccfd/src/HTTPBase.php
@@ -20,17 +20,17 @@
  */
 
 class HTTPBase{
-  var $server;
-  var $numservers;
-  var $url;
-  var $queries;
-  var $allowed_fields;
-  var $num_allowed_fields;
-  var $outputstr;
-  var $isSecure;
-  var $timeout;
-  var $debug;
-  var $check_field;
+  public $server;
+  public $numservers;
+  public $url;
+  public $queries;
+  public $allowed_fields;
+  public $num_allowed_fields;
+  public $outputstr;
+  public $isSecure;
+  public $timeout;
+  public $debug;
+  public $check_field;
   function HTTPBase() {
     $this->isSecure = 0;
     $this->debug = 0;
diff --git 
a/extras/custom_filters/filters/minfraud/ccfd/src/TelephoneVerification.php 
b/extras/custom_filters/filters/minfraud/ccfd/src/TelephoneVerification.php
index fe73601..5845475 100644
--- a/extras/custom_filters/filters/minfraud/ccfd/src/TelephoneVerification.php
+++ b/extras/custom_filters/filters/minfraud/ccfd/src/TelephoneVerification.php
@@ -1,9 +1,9 @@
 <?php
 require_once ("HTTPBase.php");
 class TelephoneVerification extends HTTPBase {
-  var $server;
-  var $numservers;
-  var $API_VERSION;
+  public $server;
+  public $numservers;
+  public $API_VERSION;
   function TelephoneVerification(){
     $this->HTTPBase();
     $this->isSecure = 1;    // use HTTPS by default
diff --git a/gateway_common/donation.api.php b/gateway_common/donation.api.php
index b7c6709..174cbd5 100644
--- a/gateway_common/donation.api.php
+++ b/gateway_common/donation.api.php
@@ -5,7 +5,7 @@
  * Call with api.php?action=donate
  */
 class DonationApi extends ApiBase {
-       var $donationData, $gateway;
+       public $donationData, $gateway;
        public function execute() {
                global $wgDonationInterfaceTestMode;
 
diff --git a/tests/includes/test_gateway/test.adapter.php 
b/tests/includes/test_gateway/test.adapter.php
index 318641b..e989144 100644
--- a/tests/includes/test_gateway/test.adapter.php
+++ b/tests/includes/test_gateway/test.adapter.php
@@ -135,7 +135,7 @@
         * Returns the variable $this->dataObj which should be an instance of
         * DonationData.
         *
-        * @returns DonationData
+        * @return DonationData
         */
        public function getDonationData() {
                return $this->dataObj;
@@ -622,7 +622,7 @@
         * Returns the variable $this->dataObj which should be an instance of
         * DonationData.
         *
-        * @returns DonationData
+        * @return DonationData
         */
        public function getDonationData() {
                return $this->dataObj;

-- 
To view, visit https://gerrit.wikimedia.org/r/154596
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88830925b6531ff74fab35e1fad9e83e09689f17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits