jenkins-bot has submitted this change and it was merged.
Change subject: Use public instead of var in classes
......................................................................
Use public instead of var in classes
Change-Id: I0f28f663eba42025d072f010b5c5722b48cbeb77
---
M includes/RemoteSchema.php
M includes/ResourceLoaderSchemaModule.php
M tests/RemoteSchemaTest.php
3 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/RemoteSchema.php b/includes/RemoteSchema.php
index 45fea20..b40807f 100644
--- a/includes/RemoteSchema.php
+++ b/includes/RemoteSchema.php
@@ -8,12 +8,12 @@
const LOCK_TIMEOUT = 20;
- var $cache;
- var $http;
- var $key;
- var $revision;
- var $title;
- var $content = false;
+ public $cache;
+ public $http;
+ public $key;
+ public $revision;
+ public $title;
+ public $content = false;
/**
diff --git a/includes/ResourceLoaderSchemaModule.php
b/includes/ResourceLoaderSchemaModule.php
index 17e6e4e..118074c 100644
--- a/includes/ResourceLoaderSchemaModule.php
+++ b/includes/ResourceLoaderSchemaModule.php
@@ -17,7 +17,7 @@
class ResourceLoaderSchemaModule extends ResourceLoaderModule {
/** @var RemoteSchema $schema **/
- var $schema;
+ public $schema;
/**
diff --git a/tests/RemoteSchemaTest.php b/tests/RemoteSchemaTest.php
index ee69f40..036a96c 100644
--- a/tests/RemoteSchemaTest.php
+++ b/tests/RemoteSchemaTest.php
@@ -21,7 +21,7 @@
/** @var RemoteSchema */
private $schema;
- var $statusSchema = array( 'status' => array( 'type' => 'string' ) );
+ public $statusSchema = array( 'status' => array( 'type' => 'string' ) );
function setUp() {
parent::setUp();
--
To view, visit https://gerrit.wikimedia.org/r/154603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f28f663eba42025d072f010b5c5722b48cbeb77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
