jenkins-bot has submitted this change and it was merged.
Change subject: Use public instead of var in classes
......................................................................
Use public instead of var in classes
Change-Id: If1a3d18d28d7065bf3a164863d46d964c6192c07
---
M CentralNoticeBannerLogPager.php
M CentralNoticeCampaignLogPager.php
M CentralNoticePageLogPager.php
M CentralNoticePager.php
M TemplatePager.php
M includes/BannerMessage.php
M special/SpecialCentralNotice.php
M special/SpecialNoticeTemplate.php
M tests/CentralNoticeTest.php
9 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralNoticeBannerLogPager.php b/CentralNoticeBannerLogPager.php
index f504da4..9f6214f 100644
--- a/CentralNoticeBannerLogPager.php
+++ b/CentralNoticeBannerLogPager.php
@@ -1,7 +1,7 @@
<?php
class CentralNoticeBannerLogPager extends CentralNoticeCampaignLogPager {
- var $special;
+ public $special;
function __construct( $special ) {
$this->special = $special;
diff --git a/CentralNoticeCampaignLogPager.php
b/CentralNoticeCampaignLogPager.php
index e017610..fc02a0c 100644
--- a/CentralNoticeCampaignLogPager.php
+++ b/CentralNoticeCampaignLogPager.php
@@ -1,7 +1,7 @@
<?php
class CentralNoticeCampaignLogPager extends ReverseChronologicalPager {
- var $viewPage, $special;
+ public $viewPage, $special;
function __construct( $special ) {
$this->special = $special;
diff --git a/CentralNoticePageLogPager.php b/CentralNoticePageLogPager.php
index 563accf..2d46dd7 100644
--- a/CentralNoticePageLogPager.php
+++ b/CentralNoticePageLogPager.php
@@ -6,7 +6,7 @@
* the log only goes back 30 days.
*/
class CentralNoticePageLogPager extends ReverseChronologicalPager {
- var $viewPage, $special, $logType;
+ public $viewPage, $special, $logType;
/**
* Construct instance of class.
diff --git a/CentralNoticePager.php b/CentralNoticePager.php
index a32ef26..71c741d 100644
--- a/CentralNoticePager.php
+++ b/CentralNoticePager.php
@@ -1,9 +1,9 @@
<?php
class CentralNoticePager extends TemplatePager {
- var $viewPage, $special;
- var $editable;
- var $filter;
+ public $viewPage, $special;
+ public $editable;
+ public $filter;
function __construct( $special, $filter = '' ) {
parent::__construct( $special, $filter );
diff --git a/TemplatePager.php b/TemplatePager.php
index 01a3510..c612f3b 100644
--- a/TemplatePager.php
+++ b/TemplatePager.php
@@ -8,9 +8,9 @@
* that part of CN.
*/
class TemplatePager extends ReverseChronologicalPager {
- var $onRemoveChange, $viewPage, $special;
- var $editable;
- var $filter;
+ public $onRemoveChange, $viewPage, $special;
+ public $editable;
+ public $filter;
function __construct( $special, $filter = '' ) {
$this->special = $special;
diff --git a/includes/BannerMessage.php b/includes/BannerMessage.php
index 8e54e23..914cf3f 100644
--- a/includes/BannerMessage.php
+++ b/includes/BannerMessage.php
@@ -46,7 +46,7 @@
/**
* Obtain the raw contents of the message; stripping out the stupid
<message-name> if it's blank
*
- * @returns null|string Will be null if the message does not exist,
otherwise will be
+ * @return null|string Will be null if the message does not exist,
otherwise will be
* the contents of the message.
*/
function getContents( $lang ) {
diff --git a/special/SpecialCentralNotice.php b/special/SpecialCentralNotice.php
index ab095ca..b876612 100644
--- a/special/SpecialCentralNotice.php
+++ b/special/SpecialCentralNotice.php
@@ -6,7 +6,7 @@
const HIGH_PRIORITY = 2;
const EMERGENCY_PRIORITY = 3;
- var $editable, $centralNoticeError;
+ public $editable, $centralNoticeError;
function __construct() {
// Register special page
diff --git a/special/SpecialNoticeTemplate.php
b/special/SpecialNoticeTemplate.php
index b9b6595..98f8d2e 100644
--- a/special/SpecialNoticeTemplate.php
+++ b/special/SpecialNoticeTemplate.php
@@ -1,7 +1,7 @@
<?php
class SpecialNoticeTemplate extends CentralNotice {
- var $editable, $centralNoticeError;
+ public $editable, $centralNoticeError;
function __construct() {
// Register special page
diff --git a/tests/CentralNoticeTest.php b/tests/CentralNoticeTest.php
index 155a502..7af0a94 100644
--- a/tests/CentralNoticeTest.php
+++ b/tests/CentralNoticeTest.php
@@ -19,7 +19,7 @@
protected $campaignArray;
- var $campaignId;
+ public $campaignId;
protected function setUp() {
parent::setUp();
--
To view, visit https://gerrit.wikimedia.org/r/154566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1a3d18d28d7065bf3a164863d46d964c6192c07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
