jenkins-bot has submitted this change and it was merged.
Change subject: Use public instead of var in classes
......................................................................
Use public instead of var in classes
Change-Id: I0c059515cbf0fa8ef3846526a989f1a322fcd8ae
---
M common/Base.php
M common/Common.php
M engines/LuaCommon/LanguageLibrary.php
M engines/LuaCommon/LuaCommon.php
M engines/LuaSandbox/Engine.php
M engines/LuaStandalone/LuaStandaloneEngine.php
M tests/engines/LuaCommon/LuaEnvironmentComparisonTest.php
M tests/engines/LuaSandbox/LuaSandboxInterpreterTest.php
M tests/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
9 files changed, 13 insertions(+), 13 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/common/Base.php b/common/Base.php
index 8bd0d9f..3de0ce8 100644
--- a/common/Base.php
+++ b/common/Base.php
@@ -266,9 +266,9 @@
/**
* @var ScribuntoEngineBase
*/
- var $engine;
+ public $engine;
- var $code, $chunkName;
+ public $code, $chunkName;
public function __construct( $engine, $code, $chunkName ) {
$this->engine = $engine;
diff --git a/common/Common.php b/common/Common.php
index 523d7cd..dc36ec7 100644
--- a/common/Common.php
+++ b/common/Common.php
@@ -117,7 +117,7 @@
* normally abort the request, instead it is caught and shown to the user.
*/
class ScribuntoException extends MWException {
- var $messageName, $messageArgs, $params;
+ public $messageName, $messageArgs, $params;
/**
* @param $messageName string
diff --git a/engines/LuaCommon/LanguageLibrary.php
b/engines/LuaCommon/LanguageLibrary.php
index a289dbb..5a4ad5b 100644
--- a/engines/LuaCommon/LanguageLibrary.php
+++ b/engines/LuaCommon/LanguageLibrary.php
@@ -3,8 +3,8 @@
class Scribunto_LuaLanguageLibrary extends Scribunto_LuaLibraryBase {
const MAX_LANG_CACHE_SIZE = 20;
- var $langCache = array();
- var $timeCache = array();
+ public $langCache = array();
+ public $timeCache = array();
function register() {
// Pre-populate the language cache
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index 80a1836..cd55585 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -791,7 +791,7 @@
}
class Scribunto_LuaError extends ScribuntoException {
- var $luaMessage, $lineMap = array();
+ public $luaMessage, $lineMap = array();
function __construct( $message, $options = array() ) {
$this->luaMessage = $message;
diff --git a/engines/LuaSandbox/Engine.php b/engines/LuaSandbox/Engine.php
index 85ecdb7..d8d2b29 100644
--- a/engines/LuaSandbox/Engine.php
+++ b/engines/LuaSandbox/Engine.php
@@ -209,7 +209,7 @@
}
class Scribunto_LuaSandboxInterpreter extends Scribunto_LuaInterpreter {
- var $engine, $sandbox, $libraries, $profilerEnabled;
+ public $engine, $sandbox, $libraries, $profilerEnabled;
const SAMPLES = 0;
const SECONDS = 1;
diff --git a/engines/LuaStandalone/LuaStandaloneEngine.php
b/engines/LuaStandalone/LuaStandaloneEngine.php
index ddd7c56..d8fe91e 100644
--- a/engines/LuaStandalone/LuaStandaloneEngine.php
+++ b/engines/LuaStandalone/LuaStandaloneEngine.php
@@ -2,7 +2,7 @@
class Scribunto_LuaStandaloneEngine extends Scribunto_LuaEngine {
static $clockTick;
- var $initialStatus;
+ public $initialStatus;
public function load() {
parent::load();
@@ -128,7 +128,7 @@
class Scribunto_LuaStandaloneInterpreter extends Scribunto_LuaInterpreter {
static $nextInterpreterId = 0;
- var $engine, $enableDebug, $proc, $writePipe, $readPipe, $exitError,
$id;
+ public $engine, $enableDebug, $proc, $writePipe, $readPipe, $exitError,
$id;
function __construct( $engine, $options ) {
$this->id = self::$nextInterpreterId++;
diff --git a/tests/engines/LuaCommon/LuaEnvironmentComparisonTest.php
b/tests/engines/LuaCommon/LuaEnvironmentComparisonTest.php
index 24f398c..196e4a8 100644
--- a/tests/engines/LuaCommon/LuaEnvironmentComparisonTest.php
+++ b/tests/engines/LuaCommon/LuaEnvironmentComparisonTest.php
@@ -6,12 +6,12 @@
* @group LuaStandalone
*/
class Scribunto_LuaEnvironmentComparisonTest extends MediaWikiTestCase {
- var $sandboxOpts = array(
+ public $sandboxOpts = array(
'memoryLimit' => 50000000,
'cpuLimit' => 30,
'allowEnvFuncs' => true,
);
- var $standaloneOpts = array(
+ public $standaloneOpts = array(
'errorFile' => null,
'luaPath' => null,
'memoryLimit' => 50000000,
diff --git a/tests/engines/LuaSandbox/LuaSandboxInterpreterTest.php
b/tests/engines/LuaSandbox/LuaSandboxInterpreterTest.php
index 5f59e0c..84ece34 100644
--- a/tests/engines/LuaSandbox/LuaSandboxInterpreterTest.php
+++ b/tests/engines/LuaSandbox/LuaSandboxInterpreterTest.php
@@ -8,7 +8,7 @@
* @group LuaSandbox
*/
class Scribunto_LuaSandboxInterpreterTest extends Scribunto_LuaInterpreterTest
{
- var $stdOpts = array(
+ public $stdOpts = array(
'memoryLimit' => 50000000,
'cpuLimit' => 30,
);
diff --git a/tests/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
b/tests/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
index e87fbdf..9d4f072 100644
--- a/tests/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
+++ b/tests/engines/LuaStandalone/LuaStandaloneInterpreterTest.php
@@ -8,7 +8,7 @@
* @group LuaStandalone
*/
class Scribunto_LuaStandaloneInterpreterTest extends
Scribunto_LuaInterpreterTest {
- var $stdOpts = array(
+ public $stdOpts = array(
'errorFile' => null,
'luaPath' => null,
'memoryLimit' => 50000000,
--
To view, visit https://gerrit.wikimedia.org/r/154669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c059515cbf0fa8ef3846526a989f1a322fcd8ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
