Tobias Gritschacher has submitted this change and it was merged.
Change subject: Added badge template
......................................................................
Added badge template
Change-Id: I4cf009f834b2bbd9a38066318ffd1fd4cdf4ceb3
---
M lib/resources/templates.php
M repo/includes/View/SiteLinksView.php
2 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Bene: Looks good to me, approved
WikidataJenkins: Verified
jenkins-bot: Checked
diff --git a/lib/resources/templates.php b/lib/resources/templates.php
index 2b26837..4e3195a 100644
--- a/lib/resources/templates.php
+++ b/lib/resources/templates.php
@@ -340,6 +340,11 @@
</tr>
HTML;
+ $templates['wb-badge'] =
+<<<HTML
+<span class="wb-badge wb-badge-$1" title="$2"></span>
+HTML;
+
$templates['wb-property-datatype'] =
<<<HTML
<div class="wb-datatype">
diff --git a/repo/includes/View/SiteLinksView.php
b/repo/includes/View/SiteLinksView.php
index efbf17b..3bd5872 100644
--- a/repo/includes/View/SiteLinksView.php
+++ b/repo/includes/View/SiteLinksView.php
@@ -2,7 +2,6 @@
namespace Wikibase\Repo\View;
-use Html;
use InvalidArgumentException;
use Message;
use Sanitizer;
@@ -363,17 +362,14 @@
/** @var ItemId $badge */
foreach ( $siteLink->getBadges() as $badge ) {
$serialization = $badge->getSerialization();
- $classes = 'wb-badge wb-badge-' .
Sanitizer::escapeClass( $serialization );
+ $classes = Sanitizer::escapeClass( $serialization );
if ( !empty( $this->badgeItems[$serialization] ) ) {
$classes .= ' ' . Sanitizer::escapeClass(
$this->badgeItems[$serialization] );
}
- $html .= Html::element(
- 'span',
- array(
- 'class' => $classes,
- 'title' => $this->getTitleForBadge(
$badge )
- )
+ $html .= wfTemplate( 'wb-badge',
+ $classes,
+ $this->getTitleForBadge( $badge )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/152215
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cf009f834b2bbd9a38066318ffd1fd4cdf4ceb3
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
