Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155431
Change subject: Prevent multiple api requests from firing
......................................................................
Prevent multiple api requests from firing
Bug: 69719
Change-Id: Ic8c2fe52aa2a0c1ae4a5ebd77859f0ce62107cd4
---
M resources/lightbulb/lightbulb.flyout.js
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/31/155431/1
diff --git a/resources/lightbulb/lightbulb.flyout.js
b/resources/lightbulb/lightbulb.flyout.js
index 10df061..553ec93 100644
--- a/resources/lightbulb/lightbulb.flyout.js
+++ b/resources/lightbulb/lightbulb.flyout.js
@@ -23,7 +23,8 @@
parser = new mw.gettingStarted.lightbulb.Parser(),
suggestionRenderer = new
mw.gettingStarted.lightbulb.SuggestionRenderer(),
currentFlyoutPageIndex, // 0-based
- mwConfig = mw.config.get( [ 'wgArticleId', 'wgUserId' ] );
+ mwConfig = mw.config.get( [ 'wgArticleId', 'wgUserId' ] ),
+ requestingSuggestions = false;
function renderFlyout() {
@@ -169,12 +170,18 @@
userId: mwConfig.wgUserId
} );
+ // Prevent multiple api requests from firing
+ if ( requestingSuggestions ) {
+ return;
+ }
+
if ( $flyout.data( 'has-suggestions' ) ) {
$flyout.toggle();
return;
}
+ requestingSuggestions = true;
api = new mw.gettingStarted.Api();
api.getLastArticleUserEdited( mw.user.getName() )
.done( function ( title ) {
@@ -189,6 +196,7 @@
positionFlyout( $flyout,
$lightbulb );
$flyout.data(
'has-suggestions', true );
+ requestingSuggestions = false;
$flyout.show();
} );
--
To view, visit https://gerrit.wikimedia.org/r/155431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8c2fe52aa2a0c1ae4a5ebd77859f0ce62107cd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
