jenkins-bot has submitted this change and it was merged.
Change subject: Don't blank .static in ve.dm.Document
......................................................................
Don't blank .static in ve.dm.Document
inheritClass already sets it, and blanking it is harmful if the
parent class puts anything in .static. This used to not be an
issue as ve.dm.Document's parent previously didn't use .static,
but OO.EventEmitter recently added a static method.
Change-Id: I3991a72b6b6e9968166ac7ba4aef9cee794a608a
---
M src/dm/ve.dm.Document.js
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.Document.js b/src/dm/ve.dm.Document.js
index 1d8c237..922aab0 100644
--- a/src/dm/ve.dm.Document.js
+++ b/src/dm/ve.dm.Document.js
@@ -89,8 +89,6 @@
/* Static methods */
-ve.dm.Document.static = {};
-
/**
* Split data into element data and meta data.
*
--
To view, visit https://gerrit.wikimedia.org/r/155464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3991a72b6b6e9968166ac7ba4aef9cee794a608a
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
