Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/155507
Change subject: Set global $wgContLang for CopyrightMessageBuilderTest ...................................................................... Set global $wgContLang for CopyrightMessageBuilderTest this test is failing on sometimes on travis, for non-english wikis, due to not controlling for the global variable. Change-Id: I8acdb23db7e1fcb3a284c6ddc6f70d182981b0d3 --- M repo/tests/phpunit/includes/CopyrightMessageBuilderTest.php 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/07/155507/1 diff --git a/repo/tests/phpunit/includes/CopyrightMessageBuilderTest.php b/repo/tests/phpunit/includes/CopyrightMessageBuilderTest.php index 40de24c..5397cae 100644 --- a/repo/tests/phpunit/includes/CopyrightMessageBuilderTest.php +++ b/repo/tests/phpunit/includes/CopyrightMessageBuilderTest.php @@ -13,12 +13,22 @@ * @licence GNU GPL v2+ * @author Katie Filbert < [email protected] > */ -class CopyrightMessageBuilderTest extends \PHPUnit_Framework_TestCase { +class CopyrightMessageBuilderTest extends \MediaWikiTestCase { + + protected function setUp() { + parent::setUp(); + + $this->setMwGlobals( array( + 'wgContLang' => Language::factory( 'qqx' ) + ) ); + } /** - * @dataProvider getBuildProvider + * @dataProvider buildShortCopyrightWarningMessageProvider */ - public function testBuild( $expectedKey, $expectedParams, $rightsUrl, $rightsText ) { + public function testBuildShortCopyrightWarningMessage( $expectedKey, $expectedParams, + $rightsUrl, $rightsText + ) { $language = Language::factory( 'qqx' ); $messageBuilder = new CopyrightMessageBuilder(); $message = $messageBuilder->build( $rightsUrl, $rightsText, $language ); @@ -27,13 +37,13 @@ $this->assertEquals( $expectedParams, $message->getParams() ); } - public function getBuildProvider() { + public function buildShortCopyrightWarningMessageProvider() { return array( array( 'wikibase-shortcopyrightwarning', array( '(wikibase-save)', - wfMessage( 'copyrightpage' )->inContentLanguage()->text(), + '(copyrightpage)', '[https://creativecommons.org Creative Commons Attribution-Share Alike 3.0]' ), 'https://creativecommons.org', -- To view, visit https://gerrit.wikimedia.org/r/155507 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8acdb23db7e1fcb3a284c6ddc6f70d182981b0d3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
