Smuggli has uploaded a new change for review.
https://gerrit.wikimedia.org/r/155516
Change subject: Small code improvment
......................................................................
Small code improvment
Don't count in loop definition
Change-Id: I5b4dc0579c5e216c716083c61ab0905c446f3612
---
M SmartList/SmartList.class.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/16/155516/1
diff --git a/SmartList/SmartList.class.php b/SmartList/SmartList.class.php
index b54d9de..ee74b94 100644
--- a/SmartList/SmartList.class.php
+++ b/SmartList/SmartList.class.php
@@ -709,7 +709,8 @@
// TODO RBV (17.05.11 16:52): Put this into abstraction
layer
if ( $aArgs['categories'] != '-' &&
$aArgs['categories'] != '' ) {
$aCategories = explode( ',',
$aArgs['categories'] );
- for ( $i = 0; $i < count( $aCategories ); $i++
) {
+ $iCnt = count( $aCategories );
+ for ( $i = 0; $i < $iCnt; $i++ ) {
$aCategories[$i] = str_replace( ' ',
'_', $aCategories[$i] );
$aCategories[$i] = "'" . trim( ucfirst(
$aCategories[$i] ) ) . "'";
}
--
To view, visit https://gerrit.wikimedia.org/r/155516
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b4dc0579c5e216c716083c61ab0905c446f3612
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Smuggli <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
